Fix dependency injection warnings from phpstan

Created on 19 March 2025, 7 months ago

Problem/Motivation

phpstan reports,

------ ------------------------------------------------------------------------------
Line src/ConditionalFieldsFormHelper.php
------ ------------------------------------------------------------------------------
346 \Drupal calls should be avoided in classes, use dependency injection instead
------ ------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------
Line src/Form/ConditionalFieldDeleteForm.php
------ ------------------------------------------------------------------------------
54 Unsafe usage of new static().
💡 See:
https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
------ ------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------
Line src/Form/ConditionalFieldEditForm.php
------ ------------------------------------------------------------------------------
48 Unsafe usage of new static().
💡 See:
https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
------ ------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------
Line src/Form/ConditionalFieldForm.php
------ ------------------------------------------------------------------------------
78 Unsafe usage of new static().
💡 See:
https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
------ ------------------------------------------------------------------------------

------ -------------------------------------------------------------
Line src/Plugin/conditional_fields/handler/TextAreaFormatted.php
------ -------------------------------------------------------------
36 Undefined variable: $selectors
------ -------------------------------------------------------------

Steps to reproduce

phpstan analyse conditional_fields

Proposed resolution

Inject the entityTypeManager dependency into the ConditionalFieldsFormHelper service and update the unit test to match.
In ConditionalFieldDeleteForm, ConditionalFieldEditForm, and ConditionalFieldForm, use the pattern $instance = parent::create() instead of re-implementing the __construct() method.
In TextAreaFormatted, comment out the code referencing the undefined variable.

Remaining tasks

Make an MR.

📌 Task

Status

Active

Version

4.0

Component

Code

Created by

🇺🇸United States BenStallings

Live updates comments and jobs are added and updated live.

Merge Requests

!73Fix dependency injection warnings from phpstan
Open
🇺🇸United States BenStallings
updated 7 months ago

Comments & Activities

Issue created by @BenStallings
Merge request !73fix dependency injection warnings → (Open) created by BenStallings
Comment 7 months ago →
🇺🇸United States BenStallings
Pipeline finished with Success
7 months ago
Total: 1321s
#452627
Issue was unassigned.
Status changed to Closed: duplicate about 1 month ago10:41pm 3 September 2025
Comment about 1 month ago →
🇺🇸United States BenStallings
see https://www.drupal.org/project/conditional_fields/issues/3544726 📌 fix phpstan warnings about variables that might not be defined Active instead
Comment about 1 month ago →
System Message
Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024