Contrib.social

All configurations are duplicated by domain...

Open on Drupal.org →
Created on 18 March 2025, 5 months ago

Drupal Version

Drupal 11.1

Domain module version

2.0.x-dev

Expected Behavior

Only creation domain specific configuration for the config form where it has explicitly allowed.

Actual Behavior

Can see that ConfigFactory doGet returns domain specific editable configuration even for configuration like core.extension.

Steps to reproduce

Looks like it's related to the fact of having activated the "Remember domain selection" in the domain configuration UI parameters.

This keeps the current select domain in session and this might cause a few problems as we can see below.

  /**
   * {@inheritdoc}
   */
  protected function doGet($name, $immutable = TRUE) {
    // If config for 'all' domains or immutable then don't override config.
    if (is_null($this->domainConfigUIManager->getSelectedDomainId())) {
      return parent::doGet($name, $immutable);
    }

Once the "Remembered" domain is kept in session we never get into the above code to return without instantiating a domain specific configuration.

  /**
   * {@inheritdoc}
   */
  public function getSelectedDomainId() {
    $id = NULL;

    $request = $this->getRequest();
    if (!is_null($request)) {
      $id = $this->currentRequest->get('domain_config_ui_domain') ?? NULL;
    }
    if (is_null($id) && isset($_SESSION['domain_config_ui_domain'])) {
      $id = $_SESSION['domain_config_ui_domain'];
    }

    return $id;
  }

Every configuration is now being duplicated as a domain specific version when updated as long as we have that `domain_config_ui_domain` in session.

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇫🇷France mably

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mably
  • Comment 5 months ago →
    🇫🇷France mably
  • Comment 5 months ago →
    🇫🇷France mably
  • Merge request !138Issue #3513800 by mably: All configurations are duplicated by domain ⚠️ → (Merged) created by mably
  • Comment 5 months ago →
    🇫🇷France mably

    Had to create two new services with lazy loading to avoid being hit by a circular dependency error.

  • Pipeline finished with Success
    5 months ago
    Total: 221s
    #451629
  • Pipeline finished with Success
    5 months ago
    Total: 428s
    #451645
  • Pipeline finished with Success
    5 months ago
    Total: 207s
    #451973
  • Pipeline finished with Success
    5 months ago
    Total: 225s
    #452002
  • Pipeline finished with Canceled
    5 months ago
    Total: 84s
    #452010
  • Pipeline finished with Canceled
    5 months ago
    Total: 211s
    #452012
  • Pipeline finished with Success
    5 months ago
    Total: 207s
    #452014
  • Comment 5 months ago →
    🇫🇷France mably
  • Comment 5 months ago →
    🇫🇷France mably
  • Pipeline finished with Failed
    5 months ago
    Total: 310s
    #452506
  • Pipeline finished with Failed
    5 months ago
    Total: 293s
    #452525
  • Pipeline finished with Failed
    5 months ago
    Total: 252s
    #452621
  • Comment 5 months ago →
    🇫🇷France mably

    Some unit tests are failing :(

  • Pipeline finished with Success
    5 months ago
    Total: 248s
    #452673
  • Pipeline finished with Success
    5 months ago
    Total: 229s
    #452682
  • Pipeline finished with Failed
    5 months ago
    Total: 361s
    #452688
  • Pipeline finished with Success
    5 months ago
    Total: 385s
    #452735
  • Pipeline finished with Success
    5 months ago
    Total: 203s
    #452973
  • Pipeline finished with Success
    5 months ago
    Total: 271s
    #452980
  • Comment 5 months ago →
    🇫🇷France mably

    All tests are passing again.

  • Pipeline finished with Success
    5 months ago
    Total: 299s
    #453011
  • Pipeline finished with Success
    4 months ago
    Total: 225s
    #453105
  • Pipeline finished with Success
    4 months ago
    Total: 224s
    #453116
  • Pipeline finished with Failed
    4 months ago
    Total: 238s
    #453141
  • Pipeline finished with Failed
    4 months ago
    Total: 231s
    #453150
  • Pipeline finished with Success
    4 months ago
    Total: 219s
    #453161
  • Pipeline finished with Canceled
    4 months ago
    Total: 96s
    #455037
  • Pipeline finished with Canceled
    4 months ago
    Total: 95s
    #455038
  • Pipeline finished with Success
    4 months ago
    Total: 219s
    #455041
  • Pipeline finished with Success
    4 months ago
    Total: 270s
    #455045
  • Comment 4 months ago →
    🇫🇷France mably
  • Pipeline finished with Canceled
    4 months ago
    Total: 195s
    #455120
  • Pipeline finished with Canceled
    4 months ago
    Total: 80s
    #455121
  • Pipeline finished with Success
    4 months ago
    Total: 489s
    #455122
  • Pipeline finished with Success
    4 months ago
    Total: 440s
    #455130
  • Pipeline finished with Success
    4 months ago
    Total: 433s
    #455485
  • Pipeline finished with Canceled
    4 months ago
    Total: 124s
    #455497
  • Pipeline finished with Success
    4 months ago
    Total: 221s
    #455498
  • Pipeline finished with Success
    4 months ago
    Total: 233s
    #455500
  • Pipeline finished with Canceled
    4 months ago
    Total: 293s
    #455532
  • Pipeline finished with Success
    4 months ago
    Total: 225s
    #455537
  • Merge request !140Issue #3513800 by mably: Tests without the fixes → (Open) created by mably
  • Pipeline finished with Success
    4 months ago
    Total: 207s
    #455546
  • Pipeline finished with Success
    4 months ago
    Total: 207s
    #455553
  • Pipeline finished with Failed
    4 months ago
    Total: 384s
    #455566
  • Pipeline finished with Success
    4 months ago
    Total: 315s
    #455577
  • Pipeline finished with Success
    4 months ago
    #455578
  • Pipeline finished with Success
    4 months ago
    Total: 212s
    #456019
  • Pipeline finished with Success
    4 months ago
    Total: 276s
    #456022
  • Pipeline finished with Failed
    4 months ago
    Total: 308s
    #456047
  • Pipeline finished with Success
    4 months ago
    Total: 232s
    #456120
  • Pipeline finished with Failed
    4 months ago
    Total: 258s
    #456207
  • Pipeline finished with Success
    4 months ago
    Total: 217s
    #456211
  • Comment 4 months ago →
    🇫🇷France mably

    MR 140 contains 3 tests that are currently failing with 2.0.x version. This MR contains only the tests.

    The related problems have been fixed in MR 138. The tests are passing fine there.

  • Pipeline finished with Success
    4 months ago
    Total: 218s
    #456963
  • Pipeline finished with Success
    4 months ago
    Total: 219s
    #456973
  • Pipeline finished with Success
    4 months ago
    Total: 280s
    #457023
  • Pipeline finished with Canceled
    4 months ago
    Total: 88s
    #457037
  • Pipeline finished with Success
    4 months ago
    Total: 227s
    #457039
  • Pipeline finished with Success
    4 months ago
    Total: 239s
    #457344
  • Pipeline finished with Success
    4 months ago
    Total: 248s
    #457358
  • Pipeline finished with Failed
    4 months ago
    Total: 553s
    #457372
  • Pipeline finished with Success
    4 months ago
    Total: 488s
    #460569
  • Comment 4 months ago →
    System Message
    • mably → committed b9dfbdcf on 2.0.x 
      Issue #3513800 by mably: All configurations are duplicated by domain ⚠️
  • Comment 4 months ago →
    🇫🇷France mably
  • Comment 4 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 16 days ago
  • Comment 16 days ago →
    🇬🇧United Kingdom Driskell

    @mably Since this code merged to beta3 we're seeing site information and any other configuration not loading on the frontend for the domain. It always loads the default configuration.

    It looks to hit this line:
    https://git.drupalcode.org/project/domain/-/blob/2.0.0-beta3/domain_conf...
    But immutable is always TRUE when loading configuration. So it never loads any domain overrides.

  • Comment 16 days ago →
    🇫🇷France mably

    Looks like a regression to me :(

    Will have to look at it.

  • Comment 16 days ago →
    🇫🇷France mably

    @driskell does removing the $immutable test fix the problem?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024