- Issue created by @Christian.wiedemann
-
christian.wiedemann →
committed eda3f9ec on 2.0.x
Issue #3513707 by christian.wiedemann: Gin LB Plus
-
christian.wiedemann →
committed eda3f9ec on 2.0.x
- 🇺🇸United States kmonty San Francisco, CA
@Christian.wiedemann I only briefly scanned this PR, as I was curious was gin_lb_plus was. I noticed some quick things
1. `core/jquery.once` no longer exists and https://www.drupal.org/project/once → should be used.
2. It looks like the PHP won't pass linting, but perhaps that isn't a concern for this project. - 🇩🇪Germany Christian.wiedemann
Hi @kmonty thanks for checking! I moved this from another module to this one. Linting should be fine but you are right with the libs. I have to remove them.
Automatically closed - issue fixed for 2 weeks with no activity.