[random test failure] ConnectionUnitTest::testOpenQueryClose

Open on Drupal.org →

Created on 18 March 2025, about 1 month ago

Problem/Motivation

Drupal\Tests\mysql\Kernel\mysql\ConnectionUnitTest::testOpenSelectQueryClose
Failed asserting that an array does not have the key 907.

core/tests/Drupal/KernelTests/Core/Database/DriverSpecificConnectionUnitTestBase.php:98
core/tests/Drupal/KernelTests/Core/Database/DriverSpecificConnectionUnitTestBase.php:178

Steps to reproduce

Proposed resolution

Instead of waiting 20ms for the connection to close, introduce a waitFor function that will test every 10ms if the connection is closed, timing out after 100ms.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

database system

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!11516[random test failure] ConnectionUnitTest::testOpenQueryClose
Closed
🇦🇺Australia mstrelan
updated 18 days ago

Comments & Activities

Issue created by @mstrelan
Merge request !11516Wait for helper → (Closed) created by mstrelan
Comment about 1 month ago →
🇦🇺Australia mstrelan
Pipeline finished with Failed
about 1 month ago
Total: 127s
#450927
Pipeline finished with Success
about 1 month ago
Total: 1748s
#450930
Comment about 1 month ago →
🇮🇹Italy mondrake 🇮🇹
Asked a question, inline.
Comment 26 days ago →
🇺🇸United States smustgrave
Is the only remaining task to determine if a trait should be used?
Comment 26 days ago →
🇦🇺Australia mstrelan
Yep and I think we should leave it for now until we find a need for it.
Comment 26 days ago →
🇺🇸United States smustgrave
Ok in that case believe this one could be good to go?
Comment 26 days ago →
🇮🇹Italy mondrake 🇮🇹
I may have missed completely how this work, but I am not sure we are really doing what we should. See question inline.
Comment 26 days ago →
🇺🇸United States smustgrave
Comment 25 days ago →
🇦🇺Australia mstrelan
Added explanation inline. It can check up to 10 times within the 100ms timeout, but that assumes it takes no time at all to check.
Comment 24 days ago →
🇮🇹Italy mondrake 🇮🇹
Comment 18 days ago →
🇦🇺Australia mstrelan
Moved the query inside the wait callback.
Comment 18 days ago →
🇺🇸United States smustgrave
Believe feedback has been addressed
Comment 18 days ago →
🇦🇺Australia mstrelan
Pipeline finished with Success
18 days ago
Total: 7530s
#472543
Comment 18 days ago →
System Message

catch → committed fb24b240 on 11.x
Issue #3513618 by mstrelan, mondrake: [random test failure]...
Comment 18 days ago →
System Message

catch → committed 0f068a5d on 10.5.x
Issue #3513618 by mstrelan, mondrake: [random test failure]...
Comment 18 days ago →
🇬🇧United Kingdom catch
Committed/pushed to 11.x, thanks! I think it's fine if we move the wait for method up if/when we find another good use case for it.
Comment 18 days ago →
System Message
catch → closed merge request !11516
Comment 4 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024