- Issue created by @phenaproxima
- ๐บ๐ธUnited States lyntechi Pennsylvania
lyndasantiago โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia libbna New Delhi, India
Hi @nagatahmed are you working on this? Because I want to give it a try.
- Assigned to nagatahmed
- ๐ฎ๐ณIndia libbna New Delhi, India
I am unassigning @nagatahmed from this issue due to no activity since March/April.
I would like to take this forward, but before starting development, I need to clarify a few things.
This issue seems to involve changing the layout of the filters. However, I am a bit unclear about the types of filters being referenced. Specifically:
- Text filter โ Could you please clarify what this refers to?
- Multiple choice filter โ Are these the checkbox filters?
- Boolean filters โ Are these referring to the "Sort by" filters?
Once these points are clarified, Iโll be able to proceed accordingly.
Thank you!
- ๐ฎ๐ณIndia libbna New Delhi, India
Hey, Before creating an MR, I wanted to discuss the approach Iโve taken to update the layout of the filters.
Iโve made the necessary code changes and attached a screenshot of the updated UI below for reference.
In the
Search.svelte
<div class="boolean-filters-wrapper"> {#each Object.entries(filterDefinitions) as [name, filter]} {#if filter._type === 'boolean'} <BooleanFilter definition={filter} {name} changeHandler={onFilterChange} /> {/if} {/each} </div>
Could you please review and let me know if this approach seems correct, or if youโd suggest any changes or improvements?
Thanks!
- ๐บ๐ธUnited States phenaproxima Massachusetts
That looks pretty good to me, and is in line with what I was imagining.