- Issue created by @phenaproxima
- ๐บ๐ธUnited States lyntechi Pennsylvania
lyndasantiago โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia libbna New Delhi, India
Hi @nagatahmed are you working on this? Because I want to give it a try.
- Assigned to nagatahmed
- ๐ฎ๐ณIndia libbna New Delhi, India
I am unassigning @nagatahmed from this issue due to no activity since March/April.
I would like to take this forward, but before starting development, I need to clarify a few things.
This issue seems to involve changing the layout of the filters. However, I am a bit unclear about the types of filters being referenced. Specifically:
- Text filter โ Could you please clarify what this refers to?
- Multiple choice filter โ Are these the checkbox filters?
- Boolean filters โ Are these referring to the "Sort by" filters?
Once these points are clarified, Iโll be able to proceed accordingly.
Thank you!
- ๐ฎ๐ณIndia libbna New Delhi, India
Hey, Before creating an MR, I wanted to discuss the approach Iโve taken to update the layout of the filters.
Iโve made the necessary code changes and attached a screenshot of the updated UI below for reference.
In the
Search.svelte
<div class="boolean-filters-wrapper"> {#each Object.entries(filterDefinitions) as [name, filter]} {#if filter._type === 'boolean'} <BooleanFilter definition={filter} {name} changeHandler={onFilterChange} /> {/if} {/each} </div>
Could you please review and let me know if this approach seems correct, or if youโd suggest any changes or improvements?
Thanks!
- ๐บ๐ธUnited States phenaproxima Massachusetts
That looks pretty good to me, and is in line with what I was imagining.
- ๐ฎ๐ณIndia libbna New Delhi, India
Hi @phenaproxima Thank you for the feedback. Iโve pushed the changes and attached screenshots for both desktop and mobile views.
Please review the complete code and let me know if any further changes are needed. - ๐ฎ๐ณIndia roshanibhangale
Hi
I have tested this issue on Drupal 11.
Steps
- Go to the Extend
- Click on the Contrib module
- Observe the the filters
After applying MR815 successfully, observe that the filter type is as per the requirement. On mobile device the filter typesa re stacked one on the other.
Hence this can be moved to RTBC +1.
Attaching the screenshot for reference.
- ๐บ๐ธUnited States phenaproxima Massachusetts
Confirmed that this looks fine at all widths. I'm sure we could touch up the styling a little bit in some ways (more vertical spacing), but that can happen separately.
I agree, this is ready to go. Tagging for backport to 2.0.x as well.
- First commit to issue fork.
-
chrisfromredfin โ
committed b1cddd51 on 2.1.x authored by
libbna โ
Issue #3512831: Improve the layout of the filters
-
chrisfromredfin โ
committed b1cddd51 on 2.1.x authored by
libbna โ
-
chrisfromredfin โ
committed 77287421 on 2.0.x authored by
libbna โ
Issue #3512831: Improve the layout of the filters
-
chrisfromredfin โ
committed 77287421 on 2.0.x authored by
libbna โ
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
merged to 2.1.x and cherry-picked clean to 2.0.x