Fix PHPStan issues

Created on 13 March 2025, 2 months ago

Problem/Motivation

Fix PHPStan issues, as reported by Gitlab CI.

πŸ“Œ Task
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium svendecabooter Gent

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @svendecabooter
  • First commit to issue fork.
  • First commit to issue fork.
  • Merge request !27Fix phpstan issues β†’ (Open) created by Unnamed author
  • Pipeline finished with Failed
    25 days ago
    Total: 288s
    #477841
  • πŸ‡§πŸ‡ͺBelgium aren33k

    Not sure about the extends β€˜@internal class’ for SetInlineBlockDependencyWithContextTranslation and TranslatableOverridesSectionStorage. I made a copy of those classes without the internal tag, which solved the phpstan error.

    Tests are failing, so needs some more work.

  • πŸ‡§πŸ‡ͺBelgium svendecabooter Gent

    I think it would be better to ignore the PHPStan error about the internal class usage, by ignoring it through a phpstan.neon file in the project, rather than copying over the whole PHP class from core...

    Although just ignoring it might give a false sense of security, since we are overriding an internal class, that might suddenly break without BC warnings. But that should probably be covered by test scenario's.

Production build 0.71.5 2024