PHPStan hates us cuz we're ignoring something we don't see any more

Created on 12 March 2025, 21 days ago

Problem/Motivation

 ------ ------------------------------------------------------------------------------------------------------ 
  Line   src/Activator/RecipeActivator.php                                                                     
 ------ ------------------------------------------------------------------------------------------------------ 
         Ignored error pattern #^Call to function method_exists\(\) with                                       
         'Drupal\\\\Core\\\\Recipe\\\\Recipe' and 'getExtra' will always                                       
         evaluate to true\.$# (function.alreadyNarrowedType) in path                                           
         /builds/project/project_browser/web/modules/custom/project_browser/src/Activator/RecipeActivator.php  
         was not matched in reported errors.                                                                   
 ------ ------------------------------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/RecipeActivatorTest.php                                                                     
 ------ ------------------------------------------------------------------------------------------------------------- 
         Ignored error pattern #^Call to function method_exists\(\) with                                              
         'Drupal\\\\Core\\\\Recipe\\\\Recipe' and 'getExtra' will always                                              
         evaluate to true\.$# (function.alreadyNarrowedType) in path                                                  
         /builds/project/project_browser/web/modules/custom/project_browser/tests/src/Kernel/RecipeActivatorTest.php  
         was not matched in reported errors.                                                                          
 ------ -------------------------------------------------------------------------------------------------------------

Steps to reproduce

https://git.drupalcode.org/project/project_browser/-/jobs/4642312

Proposed resolution

I think get rid of the things we're ignoring in phpstan.neon cuz we don't need to any more? (I would love to know why not.)

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States chrisfromredfin Portland, Maine

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @chrisfromredfin
Comment 21 days ago →
🇺🇸United States tim.plunkett Philadelphia
What job is this on? hard to tell from the link above.

I am getting PHPstan passes locally with both PHPStan 1 and 2
Comment 21 days ago →
🇺🇸United States tim.plunkett Philadelphia
Also those ignores were done conditionally: 📌 Switch to conditional usage of PHPStan for upstream incpompatibilies Active
Comment 21 days ago →
🇮🇳India jaydev bhatt Pune, Maharashtra
Comment 21 days ago →
🇮🇳India jaydev bhatt Pune, Maharashtra
in one of the other issue i had the same thing happening ... and there was no actual error. if the pattern are not use anymore we can remove it from the phpstan-baseline-no-getExtras.neon.
Comment 20 days ago →
🇺🇸United States chrisfromredfin Portland, Maine
Tim ended up fixing this in a separate issue

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024