- Issue created by @traviscarden
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
One more thing: the issue queue component is also hyphenated, because that seemed to match the dominant spelling.
We can change the APIs (PHP API, internal HTTP API) easily at this alpha stage.
Let's make it consistent, and execute your conclusion π So that means:
- π Standardize on the hyphenated "auto-save" and its variants--auto_save, and AutoSave.
- π Document the decision.
- Yes, let's make this consistent too.
- π Determine if there are any UI strings that we want to change.
- No need, we can just do it.
Ideally, we'd be able to configure
cspell
to forbidautosave
andAutosave
, but allowauto-save
,Auto-save
andAuto-Save
. That'd catch everything AFAICT? - Merge request !779Standardize on hyphenated spelling of "auto-save" β (Merged) created by traviscarden
- πΊπΈUnited States traviscarden
I think I got all but one thing, @wim leers: Where should we document the standard? I didn't see a place that it seemed like it fit.
I've updated the issue summary to clarify that I mean to let the dev team know about it after it's been committed, just to prevent surprise and confusion.
Also, I want credit for the fact that my initial analysis in the issue summary already included the issue queue component. I don't want that counting against me if you and I ever get into some kind of contest, @wim leers. π
Finally, I see the
cpsell
job failed. Am I crazy, or did it fail because it found a forbidden word in the directive with which I forbad it indictionary.txt
? π€¨ Well, maybe it's an easy fix--maybe the inline comments confuse it... but it's time for me to log off for the night. @wim leers, maybe you know the solution off the top of your head. - πͺπΈSpain fjgarlin
You might need to actually ignore the project's
dictionary.txt
from the cspell configuration. - πΊπΈUnited States traviscarden
I guess that makes sense, @fjgarlin, since these are the first negative terms--in other words,
dictionary.txt
was probably already being scanned, but it always passed because it contained all of its own terms. πSo the tests pass now. Bumping priority since this affects APIs, and we don't want to start to drift and get out of sync. On that account, I'm going to go ahead and assign directly to @wim leers to see if we can rush it through. Ready for review!
-
wim leers β
committed d594ecbb on 0.x authored by
traviscarden β
Issue #3512357 by traviscarden, fjgarlin, wim leers: Standardize on `...
-
wim leers β
committed d594ecbb on 0.x authored by
traviscarden β
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Thanks, fellow nitpicker! π€π
Automatically closed - issue fixed for 2 weeks with no activity.