- Issue created by @catch
- π¬π§United Kingdom catch
CSS is added on https://drupal-dev.ddev.site/admin/reports/fields but doesn't actually work, maybe a weight issue?
- π¬π§United Kingdom catch
Found the problem - claro wants to extend, not override, the library.
- First commit to issue fork.
- πΊπΈUnited States smustgrave
Fixed a merge conflict but seems performance tests are failing.
- π¬π§United Kingdom catch
Updated the performance tests, but the new layout builder failures are consistent so something is going on here.
- π¬π§United Kingdom catch
Should be green now. Looked like very complicated issues in LayoutBuilderUITest but was in fact a typo in the starterkit theme library definition.
- π§πͺBelgium borisson_ Mechelen, π§πͺ
It is green now, and we're decreasing the page weight, that's great.
I am not sure about moving the file though, people are not supposed to reference the file by path, but it seems like it increases the likelihood this will be a breaking change? - π¬π§United Kingdom catch
@borisson_ the
moved_files
definition supports libraries_override explicitly - it transparently switches the override and triggers a deprecation error. That leaves two situations:1. Someone modifying the file in hook_library_info_alter() - but data structures passed to alter hooks are excluded from backwards compatibility for this reason, we'd have the same problem changing the location in a major release too.
2. Someone directly referencing the file in a separate library definition, this feels very, very unlikely because until this MR it was loaded on every request anyway, so it would result in double-loading.
We've also had π Move system/base component CSS to respective libraries where they exist Fixed in core since around 10.2 or 10.3, and not had any regressions reported that I'm aware of (this is one of many follow-ups to that issue to try to finish the meta).
- π§πͺBelgium borisson_ Mechelen, π§πͺ
Thanks for that information. Moving to rtbc based on #10.
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- First commit to issue fork.