- Issue created by @lieb
- ๐ง๐ชBelgium swentel
Thanks for the detailed report! I'm pretty sure I've tested this at some point in time where it probably worked, but indeed, now it doesn't. I did a quick test with https://micropublish.net/ too for instance, and nothing, so either the spec has been changed, or it's more relaxed, hard to say.
However, attached is a patch which made me able to authenticate on indielogin.com and micropublish.net. From a security point of view, it doesn't seem to be less secure not validating me, so I think it's fine.
Tests will probably fail, need to look at this (locally, they don't run anymore on the DA test infrastructure due to https://www.drupal.org/project/drupalci_environments/issues/3387737#comm... ๐ Split PHP image into php(cli/apache) and yarn(node/nightwatch) Needs review ), but it would be great if you could verify the login works now.
- ๐ง๐ชBelgium swentel
New patch, suble change where the 'me' optional, but, in case it's there muse validate. Fixes the tests as well.
- ๐บ๐ธUnited States lieb
Success!! Patch -2 worked. Patch -3 resulted in "Invalid State".
I agree with your logic for Patch -3, if a "me" is returned then check to see if it matches.
I will continue to engage the discussion group about what is the correct thing here:
On a token request Post- Is "me" required?
- Is "me" optional?
- Is "me" not allowed?
Thanks once again for your quick turn around on this.
- ๐ง๐ชBelgium swentel
Hmm the invalid state is on indielogin.com? Haven't tested that patch yet, but I'll double check somewhere next week!
- ๐ง๐ชBelgium swentel
indielogin.com seems to work for me with patch 3
getting a notice though: Deprecated function: explode(): Passing null to parameter #2 ($string) of type string is deprecated in Drupal\indieweb_indieauth\Entity\IndieAuthAuthorizationCode->getScopes, so will fix that while we're at it
- ๐ฎ๐ณIndia rakesh.regar Rajasthan, India
rakesh.regar โ made their first commit to this issueโs fork.
- Merge request !7Issue #3511761 :indieweb_indieauth - not working with indielogin.com. โ (Open) created by rakesh.regar