unable to geocode with argisonline

i just made the change in 8.x-4x as you can see above can someone merge this into the latest module ?

Thanks @dianacastillo for reporting this
But it looks to me you are rushing and not providing proper context.

You mention that this change was already made for another version, but you don’t provide where this change was made, and for which version.
Can you provide reference to the parent (or related) issue you are speaking about, or just the link to “that” commit?
So this audience could better understand what kind of regression you are referring to, and how to reproduce.

Also, once you create a fork you should also generate a MR (merge request) if you ask for final review and eventual merge of it.

I will be able to better inspect this tomorrow (if you please provide better info and context) and merge it, eventually, if worth to be approved.

I better inspected this, and nothing looks wrong to me in the actual 8.x-4.x code,
and everything (still) works correctly with the "ArcGisOnline" (id = "arcgisonline") Geocoder provider.

Changing this into "Support Request" (because no proof/evidence of Bug) and closing as everything "works as designed" ...

Please provide better info context next time, and make better internal debug, because everybody time is precious.
and please don't reopen this without clear evidence / proof of your assumptions..

Adding reference to the parent issue, that I had do autonomously look for ... and find,
and that wasn't approved and merged, because not needed.

It doesnt work for me with the lower case. maybe you arent testing it on a linux machine?

Well ... the server type shouldn't make any difference in my opinion,
BUT (anyway) of course we are also testing all this on Linux based servers.

More specifically it works correctly locally on DDEV docker web image: https://hub.docker.com/r/ddev/ddev-webserver
and it also works correctly here: https://www.geodemocracy.com/drupal_geofield_stack_demo/web/
that is (of course) based on linux servers ...

BUT, rather then going around vague assumptions, why you don't provide more info on your error logs ... ?
what is not working with your "arcgisonline" provider instance?
Are you able to XDebug what is happening on your code workflow?
Are you checking it locally .. or directly on the production server? (not nice practice, in such latter case).

I am pretty confident that it could highly depend on your specific configuration setup. May be something was messed up in your Arcgisonline configuration setup ...
Would highly recommend you to remove all of it and re require it via composer
composer require geocoder-php/arcgis-online-provider
and re-enable it from scratch with your Drupal backend configuration.

The original lower case
id = "arcgisonline"
never changed over the last bunch of years, and no-one reported this same issue of your, for a Geocoder provider that is basically free for use, and definitely much used also with this Drupal Geocoder module ...
No-one else have reported this same issue ...

I am using lando and php 8.2 I just tried again - with this code I get an error :/**
* Provides an ArcGisOnline geocoder provider plugin.
*
* @GeocoderProvider(
* id = "arcgisonline",
* name = "ArcGisOnline",
* handler = "\Geocoder\Provider\ArcGISOnline\ArcGISOnline",
* arguments = {
* "sourceCountry" = ""
* }
* )
*/

with this code I dont /**
* Provides an ArcGisOnline geocoder provider plugin.
*
* @GeocoderProvider(
* id = "ArcGISOnline",
* name = "ArcGisOnline",
* handler = "\Geocoder\Provider\ArcGISOnline\ArcGISOnline",
* arguments = {
* "sourceCountry" = ""
* }
* )
*/

this is the error i get

https://account-stage.americorps.gov/admin/config/system/geocoder/geocoder-provider
Message	Drupal\Component\Plugin\Exception\PluginNotFoundException: The "ArcGISOnline" plugin does not exist. Valid plugin IDs for Drupal\geocoder\ProviderPluginManager are: ArcGisOnline, googlemaps, googlemaps_business, random, file, gpxfile, geojsonfile, kmlfile in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of /mnt/www/html/vistacampstg/docroot/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

and the geocoder.geocoder_provider.argsonline.yml has this so for some reason hte plugin has to have the exact case as the plugin thats why if i change the id to be ArcGISOnline it works

uuid: 15459270-97d6-4454-b498-aaed5cf1fe25
langcode: en
status: true
dependencies: { }
id: arcgisonline
label: ArcGisOnline
plugin: ArcGISOnline
configuration:
geocoder:
locale: ''

i have this in my composer (not sure why its there it was there when i got on the project ) maybe its related to the problem ? "autoload": {

      "psr-4": {
            "Geocoder\\Provider\\ArcGISOnline\\": ""
        },
        "exclude-from-classmap": [
            "/Tests/"
        ]
    },

I am also having hits issue. I used composer to require ArcGIS with the latest version of geocoder and it still does not appear in the plugin list. Is there something else i need to do?

Hey ok ... let's hopefully solve all this, once and for all.
I made a definitive test (using the new Drupal CMS) that clearly proves how the geocoder-php/arcgis-online-provider geocoder provider is correctly required and works correctly with the current version of the Geocoder module (8.x-4.x).

Please accomplishe the following steps, to achieve the same evidence:

1. Install the new Drupal CMS (https://new.drupal.org/docs/drupal-cms/get-started/install-drupal-cms) choosing the Events recipe/profile: the Events recipe requires Geofield, Leaflet and Geocoder modules, and also by default the geocoder-php/nominatim-provider provider ...

2. once accomplished point 1, then require the geocoder-php/arcgis-online-provider geocoder provider with the following ddev / composer command:

ddev composer require geocoder-php/arcgis-online-provider

and clear the drupal cache (drush cr)

3. go to the Geocoder provider settings (/admin/config/system/geocoder/geocoder-provider) to have evidence that the ArcGisOnline is now correctly available among the options of the Geocoder Providers options (see the attached screenshot).

and that's it ...

Please, for further informations and issues on to how correctly add Gecoder 3.x | 4.x providers please refer to this longstanding and still open issue: Gecoder https://www.drupal.org/project/geocoder/issues/3153678 🐛 How to add Gecoder 3.x providers Needs review