Add to cart form does not display certain variation types

As a note, I flagged this as the 2.40 version because that is the version I am testing with but I linked the code from the 3.0.x version because it is still present in the latest version of the module.

Also as a note, I have products with multiple variation types and they display both variation types. So the intent of the original issue has not been broken by the proposed patch as far as I can tell.

ccjjmartin → changed the visibility of the branch 3511232-add-to-cart to hidden.

ccjjmartin → closed merge request !418

The currently proposed MR appears to be breaking tests from the original parent issue, this will need some more work:

---- Drupal\Tests\commerce_cart\Functional\MultipleCartMultipleVariationTypesTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Fail      Other      phpunit-63.xml       0 Drupal\Tests\commerce_cart\Function
    PHPUnit Test failed to complete; Error: PHPUnit 10.5.45 by Sebastian Bergmann and contributors.
    
    Runtime:       PHP 8.3.17
    Configuration: /builds/issue/commerce-3511232/web/core/phpunit.xml.dist
    
    F                                                                   1 / 1 (100%)
    
    HTML output was generated.
    http://localhost/web/sites/simpletest/browser_output/Drupal_Tests_commerce_cart_Functional_MultipleCartMultipleVariationTypesTest-1-18769668.html
    http://localhost/web/sites/simpletest/browser_output/Drupal_Tests_commerce_cart_Functional_MultipleCartMultipleVariationTypesTest-2-18769668.html
    http://localhost/web/sites/simpletest/browser_output/Drupal_Tests_commerce_cart_Functional_MultipleCartMultipleVariationTypesTest-3-18769668.html
    
    
    Time: 00:23.784, Memory: 6.00 MB
    
    Multiple Cart Multiple Variation Types (Drupal\Tests\commerce_cart\Functional\MultipleCartMultipleVariationTypes)
     ✘ Add to cart
       ┐
       ├ Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "Color" not found.
       │
       │ /builds/issue/commerce-3511232/vendor/behat/mink/src/Element/TraversableElement.php:271
       │ /builds/issue/commerce-3511232/modules/cart/tests/src/Functional/MultipleCartMultipleVariationTypesTest.php:174
       ┴
    
    1 test triggered 1 deprecation:
    
    1) /builds/issue/commerce-3511232/web/core/modules/views/src/ViewsConfigUpdater.php:258
    The update to convert "numeric" arguments to "entity_target_id" for entity reference fields for view "profiles" is deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Profile, module and theme provided configuration should be updated. See https://www.drupal.org/node/3441945
    
    Triggered by:
    
    * Drupal\Tests\commerce_cart\Functional\MultipleCartMultipleVariationTypesTest::testAddToCart
      /builds/issue/commerce-3511232/modules/cart/tests/src/Functional/MultipleCartMultipleVariationTypesTest.php:168
    
    FAILURES!
    Tests: 1, Assertions: 31, Failures: 1, Deprecations: 1.

Looks like this is actually related to variation types with no attributes. Seems like the component type commerce_product_variation_attributes expects the variation types to have attributes in order to be shown. Even then though the cart is still broken and not displaying the variation attribute label.

Adding an attribute to the product seems to have resolved my immediate issues, a possible "fix" for this could either be some error handling feedback to the user to let them know attributes are required. Or have a fallback to the title handler if no attributes are provided by the user.

ccjjmartin → changed the visibility of the branch 3511232-add-to-cart-2 to hidden.

Don't use either of the MRs or patches. A different solution entirely will be needed once an approach is determined.

I don't think we want to solve this programatically... This to me is a configuration issue... The fallback that currently exists in the code and that is touched by the patch is in case a product type reference multiple variations types which cannot be supported by the attributes widget.

This is more like " won't fix" to me.