Fix extra slash in redirect for profiles that define finish_url

Created on 4 March 2025, 4 months ago

Problem/Motivation

The install_goto() function expects a relative path even though since Drupal 7 paths should have a leading slash. This causes an extra leading slash to be added, resulting in a redirect or error after installation completes.

Proposed resolution

Add leading slash to installer paths before calling install_goto().
To avoid breaking profiles that depend on install_goto() to add a leading slash to their finish_url, strip the leading slashes from paths in install_goto() and continue adding the leading slash.
Deprecate using a relative path for finish_url
Remove the workaround in Drupal 12.

API changes

Using a path without a leading slash in the finish_url value of an install profile is deprecated.

Data model changes

None.

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

install system

Created by

🇺🇸United States darren oh Lakeland, Florida

Live updates comments and jobs are added and updated live.

Merge Requests

!11373Fix extra slash in redirect for profiles that define finish_url
Open
🇺🇸United States darren oh
updated 4 months ago

Comments & Activities

Issue created by @darren oh
Merge request !11373Issue #3510966: Fix extra slash in redirect for install profiles that define finish_url → (Open) created by darren oh
Comment 4 months ago →
🇺🇸United States darren oh Lakeland, Florida
Pipeline finished with Failed
4 months ago
Total: 2776s
#439942
Comment 4 months ago →
🇺🇸United States smustgrave
Proposed solution doesn't line up with the MR.

But if this is breaking installation definitely should have test coverage

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024