Multiple refunds not working correctly

Created on 3 March 2025, 3 months ago

Problem/Motivation

After a visitor has placed/payed his order, the shop may has to refund several items in several steps. The "Refunded" amount should sum up all refunds on /admin/commerce/orders/%ID/payments, but it doesn't in a reliable way.

Steps to reproduce

1. Customer places an order for e.g. 7 EUR and pays via PayPal.
2. Shop admin refunds 1 EUR on this order. "Refund" amount is 1 EUR (correct, screenshot 2).
3. Another refund of 2 EUR is made on the same order. After saving the refund, the "Refound" amount is 3 EUR (correct, screenshot 3). But after reloding the same page, it shows just 2 EUR (false, screenshot 4).
4. If I try to add onother refund an message "An error occurred while refunding the payment." is displayed and a log entry containing a message (containing "RESOURCE_NOT_FOUND") is created in drupal.

I took a lock at the correspendending "Incoming webhook request" at the drupal log. The second request has an "amount" of 2 EUR and an "total_refunded_amount" of 3 EUR. This could be the source of this bug; the total_refunded_amount matters. If I remove the Weebhook ID, anything seems working fine related to this issue.

🐛 Bug report

Status

Active

Version

1.0

Component

PayPal Checkout

Created by

🇩🇪Germany e5sego

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @e5sego
Comment 3 months ago →
🇩🇪Germany e5sego
Comment 3 months ago →
🇩🇪Germany e5sego
Comment about 1 month ago →
🇮🇱Israel jsacksick
I believe this issue is a duplicate of 🐛 Refunds are processed in PayPal despite expected State error in Drupal Active . We're probably refunding twice due to the webhook listener trying to update the payment as well...

We would need a way to ignore a refund initiated from Drupal, not sure how to do that though. Perhaps we could store flags on the order since there is no data field on payments.

Can you confirm that not listening to the refund event fixes this?
Comment about 1 month ago →
🇮🇱Israel jsacksick
Anyway you could test the patch from 🐛 Multiple refunds not working correctly Active ? IN the meantime closing this as a duplicate. Feel free to reopen this issue if you believe this is a duplicate.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024