- Issue created by @swentel
- 🇮🇳India keshav patel
@swentel →
Please check that "file_validate_extensions" is mistakenly substituted by "FileImageDimensions", it should be changed to "FileExtension". - 🇺🇸United States apmsooner
We will probably need to create a 4.x new branch with core dependency ^10.3 || 11 to handle this as I believe these changes to file logic were introduced in 10.3 and therefore not compatible with 10.2. I'd say let me do that first and then can reassign this issue to that branch.
- 🇧🇪Belgium swentel
10.2.x is EOL, so just up the constraint of the module to 10.3 - that's good enough imo. A new branch seems way overkill for that.
- 🇧🇪Belgium swentel
Also, those validations area introduced in 10.2.0, so it's fine no?
- 🇺🇸United States apmsooner
PHP stan says they were introduced in 10.3? https://git.drupalcode.org/project/custom_field/-/jobs/4499168
- 🇧🇪Belgium swentel
Hmm, change record says 10.2.0, and in 10.4.x branch of DC too: https://git.drupalcode.org/project/drupal/-/blob/10.4.x/core/modules/fil...
- 🇺🇸United States apmsooner
Okay let me test this. If you can please push the change to the issue fork, i can test easier also.
- 🇧🇪Belgium swentel
Pushed! (sorry, needed patches file for composer.patches for a couple of projects quickly, so did that first :)
-
apmsooner →
committed 46ade135 on 3.1.x authored by
swentel →
Issue #3510733 by swentel, keshav patel: File validators have changed
-
apmsooner →
committed 46ade135 on 3.1.x authored by
swentel →
- 🇺🇸United States apmsooner
Thanks for the patch on this. I verified it was indeed introduced in 10.2. In 10.3 there is a trait introduced that we can use to further simplify but will cross that bridge later ;)