- Issue created by @godotislate
- Merge request !11350Issue #351057: Re-use reflection classes from container builder. β (Open) created by godotislate
- πΊπΈUnited States nicxvan
We started using this in the hook ordering issue here: π Hook ordering across OOP, procedural and with extra types Active
We started using this in the hook ordering issue here: #3485896: Hook ordering across OOP, procedural and with extra types i.e replace hook_module_implements_alter
I've reverted the HookCollectorPass changes here then, so only TwigExtensionPass is changed per the suggestion.
- πΊπΈUnited States smustgrave
Seems pretty straight forward and hasn't seemed to break anything.
There was some discussion in π Investigate possibilities to parse attributes without reflection Active (#18) whether this actually helps anything.
I looked at this again, and
Symfony\Component\DependencyInjection\ContainerBuilder::getReflectionClass()
only seems to keep track of reflection classes if thetrackingResources
class property is set to TRUE, which it isn't for Drupal. And it seems to need Symfony Config to work correctly if it were.Tempted to set to "Closed (won't fix)", but just going to put back to Active for now in case there's more discussion needed.