🐛 Once previewed in XB an entity with no changes will still show up in "Review x changes" Active solves a very noticeable, in-your-face problem.
It added missing infrastructure and used it for ApiLayoutController::post() (aka what we use for generating previews: client posts the entire layout+model, server responds with preview — and we use that entire layout+model to auto-save for content entity + PageRegions).
But in principle, the same problem is true for JavaScriptComponent and AssetLibrary config entities — it's just far less prominent.
Quoting @larowlan from https://git.drupalcode.org/project/experience_builder/-/merge_requests/7...
Because we only call
::recordInitialClientSideRepresentationinsideApiLayoutControllerit means we're not storing the initial hash ofJavascriptComponents andAssetLibraryconfig entities.So when we PATCH to
\Drupal\experience_builder\Controller\ApiConfigAutoSaveControllers::patchfor updates, and that calls\Drupal\experience_builder\AutoSave\AutoSaveManager::savewe don't have a hash recorded for comparison.We need to call
recordInitialClientSideRepresentationfrom\Drupal\experience_builder\Controller\ApiConfigControllers::getfor those two entity types.And we probably should have a test for the PATCH that confirms calling it without changes doesn't create an autosave entry for them.
Active
0.0
Auto-save
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
re
But in principle, the same problem is true for JavaScriptComponent and AssetLibrary config entities — it's just far less prominent.
I think this is actually pretty easy to make happen. As soon as your have existing published component all you have to do is click "edit" for the component and this happens. So there is no way to view the code of currently published component without also having it show up in "review x changes"