Auto-saving of blocks needs to handle string-to-bool fixing

Open on Drupal.org →

Created on 26 February 2025, 6 months ago

Overview

Reported by @tedbow at 🐛 Once previewed in XB an entity with no changes will still show up in "Review x changes" Active .

ok. found 1 problem in manual testing

If only change the branding block settings in header and then change back you still have an auto-saved state which results in "review 1 changes" where it should be none.a

— @tedbow at https://git.drupalcode.org/project/experience_builder/-/merge_requests/7...

— https://git.drupalcode.org/project/experience_builder/-/merge_requests/7...

Proposed resolution

See \Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\BlockComponent::fixBooleansUsingConfigSchema() and \Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\BlockComponent::clientModelToInput().

User interface changes

🐛 Bug report

Status

Active

Version

0.0

Component

Auto-save

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Issue created by @wim leers
Comment 6 months ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
wim leers → credited larowlan → .
Comment 6 months ago →
🇺🇸United States tedbow Ithaca, NY, USA
wim leers → credited tedbow → .
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 3 months ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 5 days ago →
🇫🇮Finland lauriii Finland
Comment 4 days ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Doesn't this become obsolete thanks to 📌 ComponentSourceInterface::submitConfigurationForm and validateConfigurationForm are never called Active ? 🤔
Comment 3 days ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Related: 📌 [PP-1] Implement client-side validation of block settings Active , because that's what fixBooleansUsingConfigSchema() points to as the issue where that method will be removed.
Comment 3 days ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Manually tested this again on #3523496, and I can confirm that this is fixed there! 🥳
Comment 3 days ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Showing this working, lifting the GIF from #3523496-34: Block component instance form values not processed by validation/submit handlers → :

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024