Auto-saving of blocks needs to handle string-to-bool fixing

Created on 26 February 2025, about 2 months ago

Overview

Reported by @tedbow at πŸ› Once previewed in XB an entity with no changes will still show up in "Review x changes" Active .

ok. found 1 problem in manual testing

If only change the branding block settings in header and then change back you still have an auto-saved state which results in "review 1 changes" where it should be none.a

β€” @tedbow at https://git.drupalcode.org/project/experience_builder/-/merge_requests/7...


β€” https://git.drupalcode.org/project/experience_builder/-/merge_requests/7...

Proposed resolution

See \Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\BlockComponent::fixBooleansUsingConfigSchema() and \Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\BlockComponent::clientModelToInput().

User interface changes

πŸ› Bug report
Status

Active

Version

0.0

Component

Auto-save

Created by

πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024