[Svelte] Remove the $updated key

Created on 26 February 2025, about 2 months ago

Problem/Motivation

Once upon a time, we added an $updated writable to the Svelte code, and used it to trigger re-renders. This is because dynamically updating the projects when their installation/activation status changed, was not possible. Now that πŸ“Œ Move load() function of ProjectBrowser.svelte into a new window-scoped class Active is in, it is technical debt that actually causes flickering when certain things happen in the UI.

Proposed resolution

Completely remove that writable, which should utterly squash the flickering.

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !752Remove the $updated writable β†’ (Merged) created by phenaproxima
  • Pipeline finished with Failed
    about 2 months ago
    Total: 392s
    #435032
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 177s
    #435045
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 124s
    #435046
  • Pipeline finished with Failed
    about 2 months ago
    Total: 372s
    #435048
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    This is probably good to go. Bash it up.

  • πŸ‡ΊπŸ‡ΈUnited States tim.plunkett Philadelphia

    I think Chris should review this one as he was able to reproduce the flickering.
    But this looks good and completely explains why there was weirdness.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Sure, that makes sense. For the record, I was able to reproduce the flickering myself while working on πŸ“Œ Add a test of multiple project browsers on a page Active . If you check out that branch, enable project_browser_test_mock, then visit /project-browser/project_browser_test_mock?instances=2 and start selecting and deselecting modules for install, you'll see the flickering as well.

  • Pipeline finished with Success
    about 2 months ago
    #435058
  • Pipeline finished with Skipped
    about 2 months ago
    #435798
  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

    Yes, this seems to fix it - I could not reproduce any flickering with this patch.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    21 days ago
    Total: 1525s
    #464580
  • Pipeline finished with Canceled
    21 days ago
    Total: 683s
    #464699
  • Pipeline finished with Canceled
    21 days ago
    Total: 160s
    #464704
  • Pipeline finished with Failed
    21 days ago
    Total: 1291s
    #464709
  • Pipeline finished with Failed
    21 days ago
    Total: 1483s
    #464733
  • Pipeline finished with Failed
    21 days ago
    Total: 948s
    #465008
  • Pipeline finished with Failed
    20 days ago
    Total: 14013s
    #465019
  • Pipeline finished with Success
    20 days ago
    Total: 1907s
    #465317
  • Pipeline finished with Skipped
    20 days ago
    #465354
  • Pipeline finished with Success
    20 days ago
    Total: 1511s
    #465382
Production build 0.71.5 2024