- Issue created by @lauriii
- First commit to issue fork.
- 🇺🇸United States effulgentsia
This MR fixes the layout shift entirely within the XB canvas, because the canvas does the 2 iframe trick where the iframe isn't swapped until the page load event fires, and adding the script tags delays that page load (which script tags do even without
blocking=render
).This MR doesn't quite fix the layout shift on the published site and documents why in the code comment. I think it's worth merging this first (since it improves the in-XB editing experience), and then investigating the @todo separately.
- 🇺🇸United States effulgentsia
In addition to fixing the layout shift, this also fixes a bug with not being able to drag into the slots, so bringing it into the current sprint.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Letting @larowlan decide when to merge based on https://git.drupalcode.org/project/experience_builder/-/merge_requests/7...
@effulgentsia: see that comment thread, @larowlan was suggesting an optimization that would only work per-frame, and would not pre-load ahead of time. Slightly different than what I suggested on the call earlier :)
Either way: I don't think those optimizations are blocking, but they do merit a follow-up.
-
effulgentsia →
committed 6942e9ad on 0.x
Issue #3508974 by effulgentsia, lauriii, wim leers: Using JS components...
-
effulgentsia →
committed 6942e9ad on 0.x
- 🇺🇸United States effulgentsia
Merged to 0.x. I'll open a follow-up for the further optimizations suggested in the MR reviews.
- First commit to issue fork.
- Merge request !734Issue: #3508974:: Module preload importmap and component url → (Merged) created by larowlan
-
wim leers →
committed cf4362ea on 0.x authored by
larowlan →
Issue #3508974 by larowlan, effulgentsia, wim leers, lauriii: Using JS...
-
wim leers →
committed cf4362ea on 0.x authored by
larowlan →
Automatically closed - issue fixed for 2 weeks with no activity.