- Issue created by @penyaskito
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
I uploaded the wrong screenshot, but you get the idea.
- Merge request !11291Issue #3508822: Property constraints validation adding errors to the field element instead of just the property β (Closed) created by penyaskito
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Added failing test, which failed as expected.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Probably related:
π The Inline form error of a required, limited multiple file widget is rendered twice Needs work
- πΊπΈUnited States smustgrave
Left some small comments on the MR
If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Thanks for the review, resolved comments.
- πΊπΈUnited States smustgrave
Feedback appears to be addressed.
Leaving the one thread open for committers but concern of causing breakage is there. Maybe a follow up to come up with a generic approach?
-
longwave β
committed 2be93630 on 11.x
Issue #3508822 by penyaskito: Property constraints validation adding...
-
longwave β
committed 2be93630 on 11.x
- π¬π§United Kingdom longwave UK
I wondered whether this change could break any existing tests or workflows, and so decided to err on the side of caution and only commit this to 11.x. If anyone feels strongly that this should be backported please reopen.
Committed 2be9363 and pushed to 11.x. Thanks!
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Thanks! Added π Property constraints validation adding errors to the field element instead of just the property Active for exploring other widgets.