- Issue created by @darren oh
- Merge request !745Issue #3508547: Fix handling of symlinked recipes β (Merged) created by darren oh
- πΊπΈUnited States phenaproxima Massachusetts
This makes sense to me, and didn't break existing tests, which do already test symlink handling (see
\Drupal\Tests\project_browser\Kernel\RecipesSourceTest::testRecipesAreDiscovered()
).So I think I'm good with it.
- πΊπΈUnited States tim.plunkett Philadelphia
#4 makes me think we could add tests for this, right? Some extra fixtures for testRecipesAreDiscovered
- πΊπΈUnited States phenaproxima Massachusetts
This, to me, is a case where the use case is probably uncommon enough, and the test complex enough (it'll easily be 50 times bigger than the actual fix), that adding specific coverage isn't worth our while.
But I'm sure a test can be added if you feel strongly about it.
- πΊπΈUnited States tim.plunkett Philadelphia
I don't feel that strongly, will let Chris decide.
- First commit to issue fork.
-
chrisfromredfin β
committed 7401da78 on 2.0.x authored by
darren oh β
Issue #3508547 by darren oh: Fix handling of symlinked recipes
-
chrisfromredfin β
committed 7401da78 on 2.0.x authored by
darren oh β
- πΊπΈUnited States chrisfromredfin Portland, Maine
I'm OK with no test since (a) there's already coverage for this kind of, and (b) I'm SURE Darren will let us know if we regress it ;)
- πΊπΈUnited States darren oh Lakeland, Florida
Thanks for the quick turnaround!
Automatically closed - issue fixed for 2 weeks with no activity.