- Issue created by @marcphilipps
- Merge request !107feat(frontend_editing): display icon_default from Paragraphs in overlay with improved styling → (Merged) created by a.dmitriiev
- 🇩🇪Germany a.dmitriiev
Hi @marcphilipps,
Thank you for your suggestion, I think this would be a valuable improvement of the module. Please next time create a merge request of your changes as it will be easier for review. I have created the MR myself from your branch, but there is one problem: https://git.drupalcode.org/project/frontend_editing/-/jobs/4457641 - your changes do not pass coding standards check and therefor the MR shows many changes that are not relevant to the issue and they also break coding standards. Could you please check the changes again and make sure that you follow the coding standards? You can always check whether MR passes all checks in MR pipeline.
Thank you again,
Looking forward to see this merged.
- 🇩🇪Germany itothegore
The latest commit works flawlessly for me. I tested it with Drupal 10.4.3, and everything functions as expected.
Thanks for implementing this feature! 😊
- 🇩🇪Germany a.dmitriiev
I have fixed some more style linting issues and removed div from li element, as the idea was to mimic what paragraphs widget does, and it has li with class and inside only input.
Please check and review.
- 🇩🇪Germany itothegore
Looks good, but the elements are positioned slightly next to each other. There is an option to apply the button class to the
- element so that it appears like a container.
- 🇩🇪Germany marcphilipps
Thank you for your work on this merge request. I have tested everything, and it all works perfectly on my end. Have a nice weekend!
- 🇩🇪Germany a.dmitriiev
@itothegore, what admin theme are you using? It looks like it is Gin, right? Here are the screenshots from Gin (in blue colors) and Claro (in grey colors) from my installation. Don't you see the sidebar the same? I made even the screenshot from wide state, where the buttons are placed in columns. Maybe browser cache?
- 🇩🇪Germany itothegore
I’ve deployed the latest version, and now it looks exactly the same as on your end – blue for the Gin theme and gray for the Claro theme.
It looks great, thank you!
- 🇩🇪Germany a.dmitriiev
Automatically closed - issue fixed for 2 weeks with no activity.