PATCH request for config entities reset values that are not sent

wim leers → credited hooroomoo → .

@hoorooomoo was the one to discover it, crediting them :)

Increasing priority, because need to solve this in order to fix the rather critical 🐛 Adding component to component library results in component code and configuration being lost Active .

denormalizeFromClientSide() doesn't have to be static, instead we can convert it to an instance method that updates the instance directly.

MR as POC of #6, still needs additional test coverage.

Reviewing

Reviewing

Additional feedback. 🏓

Also, what a major oversight of mine! 🫣😬

I think the CodeComponents POST vs PATCH solution is relatively neat but wondering what other opinions are.

One more set of OpenAPI adjustments needed, then this will be RTBC.

It's a shame really that we have to do some of this mapping in the first place, and that we use id and machineName interchangeably, and similarly name and label. Should we try to clean this up before we have a stable API?

The idea/intent was that the client-side and server-side can evolve independently. Same spirit as docs/adr/0005-Keep-the-front-end-simple.md, but applied to XB's config, instead of XB's component tree data model on the server (must juggle a lot of complexity) vs client (very little complexity).

I do agree there's relatively little value in it, but also not that much harm/complexity.

No strong feelings, but perhaps the argument should be that the client MUST be kept in sync to avoid the renaming on the server side, because that does not cause significant complexity on the client?

No strong feelings either, just the usual "naming things is hard" argument - although I hope this decision doesn't come to bite us in the future.

Added NewAssetLibrary and NewPattern schemas and removed the separate hardcoded schemas for the POST cases.

No strong feelings either, just the usual "naming things is hard" argument

💯

although I hope this decision doesn't come to bite us in the future.

What decision in particular do you fear potential consequences for?

Is it https://git.drupalcode.org/project/experience_builder/-/merge_requests/8...?

AFAICT you solved both mine and @tedbow's concerns? 😄

RTBC'ing and assigning to @tedbow because I sense I'm missing something… 🫣

Thanks all!

This unblocked 🐛 Adding component to component library results in component code and configuration being lost Active !

Automatically closed - issue fixed for 2 weeks with no activity.