- Issue created by @darren oh
- Merge request !512Issue #3508008: Add global for command line scripts β (Open) created by darren oh
- πΊπΈUnited States phenaproxima Massachusetts
The Recipe command is provided by core, not Drupal CMS, and it is extremely weird for us to explicitly initialize install_state (to an empty array, no less, which might break all kinds of shit) in an install profile, where we can pretty much be guaranteed that it already exists, because install profiles only ever run in the installer.
I'm moving this to core, since this sounds like something that needs to be fixed there.
- πΊπΈUnited States darren oh Lakeland, Florida
I'll grant that I did not present the full technical case for this in the description. Core already skips validation during installation. If you look at my code, you will see that the
$install_state
global is initialized to an empty array only if it does not exist. There is zero chance that this will break anything. As I explained, without this change the global variable will not exist for command line scripts that run while installation is paused. - πΊπΈUnited States darren oh Lakeland, Florida
Unless there is a plan to remove the Recipe Installer Kit package after installation I don't know what this has to do with the Recipe Installer Kit. However, I did find that, contrary to what I was told by the Drush maintainers, global PHP variables can be set on the command line using the
--include
option to include a command file that sets a global variable in its class constructor. - πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Moving back to Needs work as the PHP tests are failing.