- Issue created by @lauriii
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
See #3507929-2: Allow adding image properties in the code editor → for how the BE piece can be unblocked there, with one difference: here we need to set
type: string, $ref: json-schema-definitions://experience_builder.module/textarea
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This issue needs to get a BE MR that is 99% identical to that in ✨ Allow adding image properties in the code editor Active : same new validation constraint, just a different set of enabled choices. Let's first land that one, which then leaves only a tiny additional
*.schema.yml
+ test coverage only change to be done over here. -
wim leers →
committed 012e368f on 0.x authored by
f.mazeikis →
Issue #3507928 by f.mazeikis, wim leers: [Back-end] Allow adding "...
-
wim leers →
committed 012e368f on 0.x authored by
f.mazeikis →
- First commit to issue fork.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
FYI: XB's OpenAPI validation may disallow and we forgot about an integration test for this — see #3507929-19: [Back-end] Allow adding "image" props in the code component editor → .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
🤩
I think reusing the existing
ui/src/components/form/components/TextArea.tsx
would prepare us better for CKEditor 5 support in the future? See https://git.drupalcode.org/project/experience_builder/-/merge_requests/7.... -
balintbrews →
committed d9f51d36 on 0.x authored by
hooroomoo →
Issue #3507928 by f.mazeikis, wim leers, lauriii, balintbrews: [Front-...
-
balintbrews →
committed d9f51d36 on 0.x authored by
hooroomoo →
- 🇳🇱Netherlands balintbrews Amsterdam, NL
Fantastic work! 👏🏻
Just noting here that as things are, code component authors will need to add
white-space: pre;
(orwhitespace-pre
with Tailwind) until we introduce using thenl2br()
function in the backend before passing the prop values. (@effulgentsia looked up the backend parts.) Automatically closed - issue fixed for 2 weeks with no activity.