Library includes components/blocks that have been disabled

This was introduced by https://git.drupalcode.org/project/experience_builder/-/commit/8c961df3c...

Which added support for the listing showing disabled config entities - needed for code components.

The status entity key has been in components since https://git.drupalcode.org/project/experience_builder/-/commit/5c1c06641...

We had coverage for JS, but not for the converse on components and patterns, so I've added that.

Testing I noticed in the MR UI you can only delete components

But in 0.x you can disable or delete.

Why would we allow deleting these? If you delete the components, they simply come back after clearing caches. It seems only disabling and enabling make sense 🤔

Either way we need a custom list builder to support disabling via the UI but preventing from showing up in the UI

Working on #8

Made sure we have enable/disable without the status key _and_ removed the delete operation
Added tests for both

Made some minor changes and extended the test, otherwise this looks good to me.

@longwave in chat:

i do wonder if

      if (!$entity->status() && $xb_config_entity_type->getKey('status') === FALSE) {

is a bit opaque and a specific interface on the config entity type would be clearer

Agreed!

1. #13: implemented in https://git.drupalcode.org/project/experience_builder/-/merge_requests/6... — with rationale for that choice at https://git.drupalcode.org/project/experience_builder/-/merge_requests/6....

   FYI: in that, I also switched to a config query because that seemed clearer and is certainly more performant than ignoring lots of (expensive!) config entity objects.

2. Also was able to get rid of all the list builder/operation complexity, by instead fixing it at the root: https://git.drupalcode.org/project/experience_builder/-/merge_requests/6...

wim leers → credited balintbrews → .

@balintbrews also expressed concerns that this change might break the "internal" vs "exposed" breakdown for 🌱 [Meta] Plan for code components Active . I explained in more detail in chat than what is in the current docs. So added that to the docs: https://git.drupalcode.org/project/experience_builder/-/merge_requests/6...

Crediting @balintbrews for the diagram, which he previously posted at #3500386-10: Code Components should render with their auto-saved state (if any) when rendered in the XB UI → , but he provided me with a lossless version :)

Simplified the check for visible-when-disabled and fixed a nit in the docs, the rest of this looks ready to me.

Automatically closed - issue fixed for 2 weeks with no activity.