Can't remove activity from a lesson

Created on 18 February 2025, 21 days ago

Problem/Motivation

When trying to remove an activity from a lesson, the activity is removed from display but not actually removed from the lesson.

Steps to reproduce

  1. Edit a lesson, eg /admin/lms/lesson/1/edit
  2. Press 'Remove' next to an activity. The activity is removed from display. If the edit page is saved, the removed activity is still not shown.
  3. Revisit the lesson or its edit page again. The activity is still there.

Proposed resolution

Investigate deletion of activities from lessons. Also check whether removing lessons from courses may have the same issue.

🐛 Bug report
Status

Active

Version

1.0

Component

Courses and lessons

Created by

🇨🇦Canada arvana Canada

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @arvana
  • First commit to issue fork.
  • 🇵🇱Poland Graber

    Ok, all green (except 2 orange ones we are aware of), merging.
    Thanks @arvana!

    Just a note about revisiting lessons that have already been started on a course after editing activities and removing one or more:
    when starting a lesson, activities for the current attempt are saved in lesson status and STAY THERE. This is especially used in case of lessons with randomization options set but this also ensures that there are no strange scoring and navigation issues after an admin changed data for lessons that are already in progress. In other words, if a student started a lesson, activities should stay and admins / teachers should also see warnings when trying to edit them. This is a slippery ground so I advise not to edit any data connected with courses that are already in progress by someone (there's a reset progress option as an action on students' view that should be used).

  • Pipeline finished with Skipped
    20 days ago
    #428923
    • graber committed 1bcd095c on 1.0.x
      Issue #3507580 by graber, arvana: Can't remove activity from a lesson
      
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024