Deprecate migrate source plugins

Created on 18 February 2025, 5 months ago

Problem/Motivation

Deprecate the migrate source plugins used for migrating legacy Drupal sites.

Steps to reproduce

Proposed resolution

Remaining tasks

Postponed on

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Postponed

Version

11.0 πŸ”₯

Component

migration system

Created by

πŸ‡³πŸ‡ΏNew Zealand quietone

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @quietone
  • Status changed to Active 2 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone
  • πŸ‡³πŸ‡ΏNew Zealand quietone

    Updated from discussion on the Migrate video call today, benjifisher, heddn, mikelutz and myself were present. πŸ“Œ [meeting] Migrate Meeting 2025-04-24 2100Z Active

  • Merge request !12580Deprecate source plugins β†’ (Open) created by quietone
  • Pipeline finished with Failed
    4 days ago
    Total: 122s
    #536708
  • Pipeline finished with Failed
    4 days ago
    #536723
  • Pipeline finished with Failed
    4 days ago
    Total: 735s
    #536795
  • First commit to issue fork.
  • Pipeline finished with Failed
    1 day ago
    Total: 127s
    #538965
  • Pipeline finished with Failed
    1 day ago
    Total: 408s
    #538973
  • πŸ‡³πŸ‡ΏNew Zealand quietone
  • Pipeline finished with Failed
    1 day ago
    Total: 451s
    #539002
  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    Alternative proposal in !12617 which deprecates DrupalSqlBase but then skips the deprecation notices for core extensions of that class; any other extensions in contrib will trigger the message as normal.

  • Pipeline finished with Success
    1 day ago
    Total: 2234s
    #539020
  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    Added some test coverage by removing test modules from the skip, and then expecting the deprecation in tests that use them. Let's see if anything else will fail now I copied in the other two source plugin deprecations from the original MR.

  • Pipeline finished with Failed
    1 day ago
    Total: 701s
    #539224
  • Pipeline finished with Canceled
    1 day ago
    Total: 129s
    #539240
  • Pipeline finished with Failed
    1 day ago
    Total: 798s
    #539241
  • Pipeline finished with Success
    1 day ago
    Total: 573s
    #539270
  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    Added similar dynamic migration messages for the EmptySource plugin and I18nQueryTrait trait and skipped the core implementations of them, they should still trigger in contrib/custom code.

  • πŸ‡ΊπŸ‡ΈUnited States mikelutz Michigan, USA

    I like that, it’s pretty slick and much fewer lines than I was expecting to have to deal with. I’m inclined to try to get this merged in early in the 10.3 cycle so that contrib has time to deal with the fallout. It leaves the β€˜hard’ problem of identifying each of the source plugins the legacy tests for the actual removal when the 12.x branch opens, but at least we don’t have to do that twice, once for @legacy annotations, and again for removal. And when we get around to doing it, we could just remove the suppressions to get a list of all affected tests easily enough.

  • πŸ‡ΊπŸ‡ΈUnited States mikelutz Michigan, USA

    mikelutz β†’ changed the visibility of the branch 3507572-deprecate-migrate-source to hidden.

  • πŸ‡ΊπŸ‡ΈUnited States mikelutz Michigan, USA

    @longwave, Do we need to add the @deprecated annotation for DrupalSqlBase, or should that just be covered with the deprecation of the whole module eventually?

  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    We can, because that will notify people via PHPStan as well as via tests or at runtime - but I suspect the PHPStan baseline will grow quite a bit.

Production build 0.71.5 2024