- Issue created by @jurgenhaas
- Merge request !111Issue #3507522 by jurgenhaas: Insert captcha widget even if placement is NULL → (Merged) created by jurgenhaas
- Status changed to Needs review
7 days ago 8:39am 23 July 2025 - First commit to issue fork.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @jurgenhaas - how sure are we, that this doesn't introduce any unwanted side-effects? Generally I'd be fine with this change, but I'm not really sure about possible edge-cases, especially in existing installations.
- 🇩🇪Germany jurgenhaas Gottmadingen
how sure are we, that this doesn't introduce any unwanted side-effects?
I'm pretty certain. Here is why:
- The method
$captchaService->insertCaptchaElement
is explicitly built to allow for a NULL placement. That must have been done on purpose. - The NULL value for placements can only happen on forms without buttons. But the assumption that forms without buttons shouldn't get a captcha is not reasonable.
So, what's the risk that I'm wrong? Well, if there is an unintended side-effect, it could only be on forms with no buttons. Do they exist and why? I think, chances are negligible.
- The method
- 🇩🇪Germany Anybody Porta Westfalica
Thanks for your feedback @jurgenhaas. I agree the risks are low enough, the benefit is much higher. Let's merge this.
-
anybody →
committed 7480d28d on 2.x authored by
jurgenhaas →
Issue #3507522 by jurgenhaas, anybody: Insert captcha widget even if...
-
anybody →
committed 7480d28d on 2.x authored by
jurgenhaas →