- Issue created by @Grimreaper
- Merge request !46Issue #3507519 by grimreaper: Remove internal from controllers and forms β (Merged) created by Grimreaper
- πΊπΈUnited States jastraat
This makes sense to me generally. The only instance I'm not sure of is the "ImportSectionFromLibraryController". Is there a use case for overriding this?
- π«π·France Grimreaper France π«π·
Currently I don't have a use case.
Just in general, I almost (in case I already did that) never put classes as internal. If people wants to override stuff, it is their responsibility to ensure the override still works.
If there is a method I absolutely don't want people to override, I mark it private.
Interface for public method where backward compatibility is checked.
For protected method, maintaining backward compatibility if possible, if not.
People have to use tools like PHPStan or something to scan their codebase and it will normally highlight problem.
- πΊπΈUnited States jastraat
Alrighty - you can override, but do so at your own risk :)
-
jastraat β
committed 27839042 on 1.2.x authored by
grimreaper β
Issue #3507519 by grimreaper: Remove internal from controllers and forms
-
jastraat β
committed 27839042 on 1.2.x authored by
grimreaper β
-
jastraat β
committed 27839042 on 2.0.x authored by
grimreaper β
Issue #3507519 by grimreaper: Remove internal from controllers and forms
-
jastraat β
committed 27839042 on 2.0.x authored by
grimreaper β
- πΊπΈUnited States jastraat
Updating this to the relevant major version.
Automatically closed - issue fixed for 2 weeks with no activity.