- Issue created by @phenaproxima
- Merge request !735Issue #3507468: EnabledSourceHandler's query result caching should also consider the contents of composer.lock β (Merged) created by phenaproxima
- πͺπΈSpain fjgarlin
The code looks good. We'll need to test it once β¨ Feature: Include option in drupalorg_jsonapi source to show only locally installed modules Active is merged.
Jobs are failing in the CI, but I'm not sure if it's related to this.
- πΊπΈUnited States phenaproxima Massachusetts
I ended up having to de-flakify some tests because for some reason, the ordering of projects changes under certain circumstances. Why, I can't say, but I definitely confirmed two things:
- The tests I changed do not actually care about order; they were just relying on order-sensitive selectors because they didn't know any better.
- The EnabledSourceHandler is storing the same exact set of results, before and after this change, and returning them to the frontend. Svelte's rendering them in a different order, for some reason.
Given that, I decided that the correct course of action here is to improve the tests and make them more accurate, rather than trying to find out exactly why the ordering is different. If the ordering mattered to these particular tests, then the tests should, like, test that.
- πͺπΈSpain fjgarlin
Setting to Needs work as there is a merge conflict.
- πΊπΈUnited States tim.plunkett Philadelphia
Reviewed this, and even went down a rabbit hole of the safety of hash_file(), but we're fine because of the file_exists() check (and because the only other error condition is if the file being hashed is over 2GB, and if your composer.lock is over 2GB, you are beyond help)
- First commit to issue fork.
-
chrisfromredfin β
committed 2bdbb029 on 2.0.x authored by
phenaproxima β
Issue #3507468: EnabledSourceHandler's query result caching should also...
-
chrisfromredfin β
committed 2bdbb029 on 2.0.x authored by
phenaproxima β
- πΊπΈUnited States chrisfromredfin Portland, Maine
feels good to me; I reviewed & so did Tim.
Automatically closed - issue fixed for 2 weeks with no activity.