Highlighted excerpt does not match apostrophe in search query.

Comments & Activities

Issue created by @davidwhthomas
Merge request !213Remove extra HTML::escape to allow highlight range to match. → (Open) created by davidwhthomas
Pipeline finished with Failed
2 months ago
Total: 593s
#426947

One of the tests fails, I'm not sure of the significance of this:

     ✘ Postprocess search results with complex keys
       ┐
       ├ Excerpt was added.                          
       ├ Failed asserting that two strings are equal.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'…·This·foo·text·bar·will·get·baz·riddled·with·<strong>·tags.·…'
       ┊ +'…·This·foo·text·bar·will·get·baz·riddled·with··tags.·…'
       │
       │ /builds/issue/search_api-3507292/tests/src/Unit/Processor/HighlightTest.php:859
       ┴

Comment 2 months ago →
🇦🇹Austria drunken monkey Vienna, Austria
Comment 2 months ago →
🇦🇹Austria drunken monkey Vienna, Austria
Thanks for reporting this issue!
However, as you see by the failing test, this problem is unfortunately not that easy to fix as we do want to have our excerpts be valid HTML, which is why we need to escape the plain text version before adding the highlighting tags. Conceivably, we could also do the highlighting on the plain-text version and then escape the text right before adding the highlighting tags, but that would require larger changes to the code.

For now, would you be able to add a regression test for this problem to HighlightTest? That way we can immediately see whether a proposed solution works as intended while also doesn’t break any existing functionality.
Comment 2 months ago →
🇦🇹Austria drunken monkey Vienna, Austria

Highlighted excerpt does not match apostrophe in search query.

When using a search query that includes an apostrophe, the highlighted search excerpt in the results does not match the apostrophe and that word remains un-highlighted.

Enable the search highlight process plugin. Perform a search with an apostrophe in the search query that matches a result. For example "Women's Law Society" will highlight "Law Society" but not "Women's"

Remove the extra HTML encoding before the search highlight is added.

Adjust the Highlight.php plugin accordingly

Merge Requests

!213Highlighted excerpt does not match apostrophe in search query.
Open

Comments & Activities

Highlighted excerpt does not match apostrophe in search query.

When using a search query that includes an apostrophe, the highlighted search excerpt in the results does not match the apostrophe and that word remains un-highlighted.

Enable the search highlight process plugin. Perform a search with an apostrophe in the search query that matches a result. For example "Women's Law Society" will highlight "Law Society" but not "Women's"

Remove the extra HTML encoding before the search highlight is added.

Adjust the Highlight.php plugin accordingly

Merge Requests

!213Highlighted excerpt does not match apostrophe in search query.Open

Comments & Activities

!213Highlighted excerpt does not match apostrophe in search query.
Open