Contrib.social

Slow performance in BookManager when $original is missing

Open on Drupal.org →
Created on 17 February 2025, 5 months ago

Problem/Motivation

In several places in BookManager, we have the line:

$original = $this->loadBookLink($node->id(), FALSE);

It's possible that $original can be FALSE (if the book node has been deleted, for example) but no error checking or handling is in place. We noticed when running our end-to-end test suite that runtime increased massively when switching from book 1.0 to 2.0 and traced the cause back to this.

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇬🇧United Kingdom nicrodgers Monmouthshire, UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024