Reset service to initial state

Hi richarddavies I think your use case is exactly what this module was built for. So it ought to do what you want. It should not keep state from message to the next, however your telling it to dedupe the queue may be the cause of the problem you are seeing. When you set the dedupe flag to TRUE it will overwrite any time in the queue that matches the uuid you have assigned. WHen deduping the queue, the last one in wins.

for example if you tried to queue up
queueUid: 12_color title:green
queueUid: 12_color title:blue
queueUid: 12_color title:yellow

Only the yellow one would exist in the queue and be sent to GovDelivery. If you set dedupeQueue to FALSE you would have all three in your queue to be sent to GovDelivery. Depending on your use case you might need to turn off deduping or make your queueUid more unique.

Let me know if any of that might explain what you are seeing. I will also double check the code to make sure there is nothing keeping state, but I am fairly sure this would have surfaced long before now if that had been happening.

I should also point out that deduping the queue can be incredibly time consuming if you are adding a lot of items and should only be done in cases where you absolutely do not want multiple possibly conflicting messages being sent.

I see it now. It is accidentally keeping state on the add* methods and failing to reset them as part of addiToQueue()

I am still a bit dumbfounded how this never surfaced on VA.gov but I suspect it is because we never changed category mid phhp session instance. I will get this resolved in the next few days.

Thank you for reporting this.

richarddavies I took your patch and added a new method that does both the addToQueue and the reset. I preserved the original call the way it was so that if there were users of the module that set the categories, email addresses or topics outside of the loop and then looped through things to set the addToQueue we would not break their code by forcibly calling reset().

It would be great if you could test this merge request out by just changing your code from addToQueue() to addToQueueAndReset()

Thank you for the quick response. Yes, I tested addToQueueAndReset() and it worked as expected.

This is fixed. I will release it shortly

This has been released with 8.x-1.11 →

Thanks again @richarddavies for your contribution.

Thanks. You should also consider updating the example code on the module homepage to use the new method.

Good catch. I updated the README but forgot to click the little button that imports it to the project page. Doing that now.