Convert all "Advanced settings" checkboxes to toggle behavior on, not off

Created on 13 February 2025, 21 days ago

The settings form for this module currently includes two checkboxes that toggle behaviors off, when the whole point of checkboxes is to toggle features on.

Thus, "Disable tax calculation" should be a checkbox that defaults to on labeled "Calculate taxes via AvaTax." Note that "enable" should not be part of the label - this is implied by the box being checked. With this change, this checkbox no longer needs a description.

"Disable document committing." should be a checkbox that defaults to checked labeled "Commit AvaTax sales invoices when orders are placed." This option can still have a desceription that reads, "Disable this if you are only calculating taxes during checkout via AvaTax but using a separate system to commit the sales invoices."

"Enable logging." is correct, but it does not need a description.

While we're at it, the "Validate addresses in checkout" checkbox needs a period and does not need a description.

For changes where the logic has been inverted, we should also include an update hook to change the actual setting names. It will be hopelessly confusing to have these mismatched. However, we cannot do this absent a new major version, so I'll create a separate ticket and we can scope this issue to just fixing the UI for now.

📌 Task

Status

Active

Version

1.0

Component

User interface

Created by

🇺🇸United States rszrama

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @rszrama
Comment 20 days ago →
🇺🇸United States rszrama
The checkbox for postal code matching is very confusing, too, because it always matches on postal code, just not necessarily the 9 digit Zip. Thus:

Match on postal code
Postal codes are 9 digits, but most people enter the first 5 digits, do you want AvaTax to match all 9 digits?

Should just be a checkbox that reads, "Validate addresses against the full 9-digit Zip code." No description necessary.
Comment 20 days ago →
🇺🇸United States rszrama
Fixed the validate shipping address checkbox as part of 🐛 HTML::escape() WSOD or "profile cannot be referenced" when manually entering a shipment that popups "Confirm your shipping address" Active .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024