- Issue created by @morbus iff
- 🇺🇸United States morbus iff
rszrama is suggesting this has something to do with Avatax.
- 🇺🇸United States morbus iff
If you head to commerce/config/avatax and uncheck "Validate addresses in checkout", the test scenario above works with no issue.
- 🇺🇸United States rszrama
Confirming I can reproduce the error. Interestingly enough, it actually works fine if you edit a shipment that already exists. That leads me to believe we could maybe make this work, which would be great - however, it should at least be tied to a different setting. We can't have something that says "validate addresses in checkout" also randomly apply to the admin UI. 🤣
- 🇺🇸United States rszrama
Oh, wow. I just realized in testing today that the specific error here is related to the fact that I was attempting (and I assume you were attempting) to create a shipment against a draft order that does not yet have an order number. The Shipping module creates a message with an order number placeholder that cannot by NULL, apparently, though I assume this worked before as casted to an empty string. Not sure.
$this->messenger()->addMessage($this->t('Saved shipment for order @order.', ['@order' => $order->getOrderNumber()]));In any case, I don't see why shipping doesn't just use the order label. I've changed that in Commerce Shipping here: 🐛 Use the order label when saving a shipment instead of order number Fixed
Since this wasn't actually a bug in AvaTax, I'm reverting this to a feature request specifically to differentiate validating addresses on checkout vs. the backend.
- 🇺🇸United States rszrama
Committed an update that separates the settings. Turns out it works just fine on the admin form once the label issue is resolved. 😄
Automatically closed - issue fixed for 2 weeks with no activity.