CSS: check Core CSS

Created on 13 February 2025, 3 months ago

Problem/Motivation

Check Core CSS files, especially the ones added on all pages to ensure they are still pertinent.

If not pertinent, remove it from theme .info.yml

📌 Task
Status

Active

Version

5.1

Component

Miscellaneous

Created by

🇫🇷France Grimreaper France 🇫🇷

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Grimreaper
  • 🇫🇷France Grimreaper France 🇫🇷
  • 🇫🇷France Grimreaper France 🇫🇷

    Core: 10.4.3

    Core module's hook_page_attachments:

    • big_pipe_page_attachments: Don't add libraries.
    • content_translation_page_attachments: Don't add libraries.
    • contextual_page_attachments: Only for admins.
    • system_page_attachments: system/base added.

    system/base:

    • css/components/align.module.css: nothing to do
    • css/components/fieldgroup.module.css: nothing to do
    • css/components/container-inline.module.css: already removed in USB
    • css/components/clearfix.module.css: already removed in USB
    • css/components/details.module.css: nothing to do
    • css/components/hidden.module.css: a little redundant with Bootstrap classes, except .hidden not present in Bootstrap.
    • css/components/item-list.module.css: nothing to do
    • css/components/js.module.css: nothing to do
    • css/components/nowrap.module.css: Bootstrap has .text-nowrap. nowrap maybe not used in Core. For one CSS selector, nothing to do.
    • css/components/position-container.module.css: nothing to do
    • css/components/reset-appearance.module.css: nothing to do
    • css/components/resize.module.css: nothing to do
    • css/components/system-status-counter.css: Only used on admin status report, to remove, if someone uses the USB theme as admin theme, will do proper theming in a follow-up issue.
    • css/components/system-status-report-counters.css: Only used on admin status report, to remove, if someone uses the USB theme as admin theme, will do proper theming in a follow-up issue.
    • css/components/system-status-report-general-info.css: Only used on admin status report, to remove, if someone uses the USB theme as admin theme, will do proper theming in a follow-up issue.
    • css/components/tablesort.module.css: already removed in USB

    Check preprocesses:

    • shortcut_preprocess_page_title: shortcut/drupal.shortcut
      - added only if admin
    • template_preprocess_update_report: update/drupal.update.admin
      - only for status report
    • template_preprocess_views_view_table: core/drupal.tableheader
      - already removed in USB
    • template_preprocess_views_view_table: core/drupal.tableresponsive
      - nothing to do
    • template_preprocess_views_ui_view_preview_section: contextual/drupal.contextual-links
      - added only if admin

    The following preprocesses don't add libraries:

    • template_preprocess_block
    • template_preprocess_block_content_add_list
    • template_preprocess_book_all_books_block
    • template_preprocess_book_navigation
    • template_preprocess_book_export_html
    • template_preprocess_book_node_export_html
    • comment_preprocess_block
    • template_preprocess_comment
    • comment_preprocess_field
    • content_moderation_preprocess_node
    • content_translation_preprocess_language_content_settings_table
    • template_preprocess_field_ui_table
    • field_ui_preprocess_form_element__new_storage_type
    • template_preprocess_file_managed_file
    • template_preprocess_file_link
    • template_preprocess_file_widget_multiple
    • template_preprocess_file_upload_help
    • template_preprocess_filter_guidelines
    • template_preprocess_text_format_wrapper
    • template_preprocess_filter_tips
    • forum_preprocess_block
    • template_preprocess_forums
    • template_preprocess_forum_list
    • template_preprocess_forum_icon
    • template_preprocess_forum_submitted
    • help_preprocess_block
    • template_preprocess_image_style_preview
    • template_preprocess_image_anchor
    • template_preprocess_image_widget
    • template_preprocess_image_formatter
    • template_preprocess_image_style
    • inline_form_errors_preprocess_form_element
    • inline_form_errors_preprocess_details
    • inline_form_errors_preprocess_fieldset
    • inline_form_errors_preprocess_datetime_wrapper
    • template_preprocess_language_negotiation_configure_form
    • template_preprocess_language_content_settings_table
    • language_preprocess_block
    • layout_builder_preprocess_language_content_settings_table
    • template_preprocess_layout
    • template_preprocess_link_formatter_link_separate
    • locale_preprocess_node
    • template_preprocess_locale_translation_update_info
    • template_preprocess_locale_translation_last_check
    • template_preprocess_media
    • media_preprocess_media_reference_help
    • template_preprocess_media_library_wrapper
    • template_preprocess_media_library_item
    • media_library_preprocess_media
    • media_library_preprocess_views_view__media_library
    • media_library_preprocess_views_view_fields
    • menu_ui_preprocess_block
    • template_preprocess_node_add_list
    • node_preprocess_html
    • node_preprocess_block
    • node_preprocess_field__node
    • template_preprocess_node
    • template_preprocess_responsive_image_formatter
    • template_preprocess_responsive_image
    • search_preprocess_block
    • template_preprocess_search_result
    • settings_tray_preprocess_block
    • shortcut_preprocess_block
    • statistics_preprocess_block
    • template_preprocess_admin_block_content
    • template_preprocess_admin_page
    • template_preprocess_system_admin_index
    • template_preprocess_system_modules_details
    • template_preprocess_system_modules_uninstall
    • template_preprocess_system_themes_page
    • template_preprocess_entity_add_list
    • system_preprocess_block
    • system_preprocess_toolbar
    • claro_preprocess_toolbar
    • template_preprocess_system_security_advisories_fetch_error_message
    • template_preprocess_taxonomy_term
    • template_preprocess_toolbar
    • toolbar_preprocess_html
    • template_preprocess_update_last_check
    • template_preprocess_update_version
    • template_preprocess_update_project_status
    • template_preprocess_update_fetch_error_message
    • user_preprocess_block
    • user_template_preprocess_default_variables_alter
    • template_preprocess_username
    • template_preprocess_user
    • views_preprocess_node
    • views_preprocess_comment
    • template_preprocess_views_view
    • template_preprocess_views_view_fields
    • template_preprocess_views_view_grouping
    • template_preprocess_views_view_field
    • template_preprocess_views_view_summary
    • template_preprocess_views_view_summary_unformatted
    • template_preprocess_views_view_grid
    • template_preprocess_views_view_grid_responsive
    • template_preprocess_views_view_unformatted
    • template_preprocess_views_view_list
    • template_preprocess_views_view_rss
    • template_preprocess_views_view_row_rss
    • template_preprocess_views_view_opml
    • template_preprocess_views_view_row_opml
    • template_preprocess_views_exposed_form
    • template_preprocess_views_mini_pager
    • views_ui_preprocess_views_view
    • template_preprocess_views_ui_display_tab_setting
    • template_preprocess_views_ui_views_listing_table
    • template_preprocess_views_ui_display_tab_bucket
    • template_preprocess_views_ui_build_group_filter_form
    • template_preprocess_views_ui_rearrange_filter_form
    • template_preprocess_views_ui_style_plugin_table

    Check Twig templates:

    • app/core/modules/announcements_feed/templates/announcements-feed-admin.html.twig: announcements_feed/drupal.announcements_feed.page
      - added only if admin
    • app/core/modules/system/templates/status-report-grouped.html.twig: core/drupal.collapse
      - nothing to do
    • app/core/modules/views/templates/views-view-grid-responsive.html.twig: views/views.responsive-grid
      - only used when this display is used, nothing to do.
  • 🇫🇷France Grimreaper France 🇫🇷

    @pdureau Are you ok with the proposed resolution?

    Only 3 CSS files to remove.

  • 🇫🇷France Grimreaper France 🇫🇷
    • grimreaper committed 698658ab on 5.1.x
      Issue #3506410 by grimreaper: CSS: remove useless CSS loaded on all...
  • 🇫🇷France Grimreaper France 🇫🇷
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024