Restore the tab to section library collection

Created on 11 February 2025, 3 months ago

Problem/Motivation

In ✨ Make section library template fieldable Active , the tab to the section library collection had been removed. Because now provided by the views.

1: there was no update in the related issue to update the view config, so existing websites, will potentially no more have a tab to the view.

2: Could the "List", "Manage fields", "Manage form display", "Manage display" tabs be moved as secondary level tabs?

Proposed resolution

I will try to provide a MR for:
- providing tab with YAML and no more views config
- moving tabs to secondary level.

✨ Feature request
Status

Active

Version

1.2

Component

User interface

Created by

πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Grimreaper
  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    Or "field UI" tabs need to be moved in Admin > Structure, not the place in Admin > Content.

  • Pipeline finished with Canceled
    3 months ago
    Total: 73s
    #421225
  • Pipeline finished with Success
    3 months ago
    Total: 151s
    #421226
  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    I made a very straight forward POC to open discussion.

  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    I agree that the field UI makes more sense under Admin Structure. What are you proposing as the parent for those tabs? Are you adding a new route?
    I also love that folks are actually trying this out!

  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    With screenshots, maybe easier to visualize :)

  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    Will index just be blank for now?

  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    I am not in favor of splitting "section" and "template" into 2 bundles, the current structure is OK.

    One of the content entity type from core that has no bundle is user. And it's equivalent of index is "admin/config/people/accounts" which is a global user account related settings form. So way more similar like the settings form you propose.

    As mentioned in the MR comments, I had to have a route to attach the Field UI routes on. And currently, no better stuff than an empty controller. Maybe with an explanatory text.

    So:
    1 if you prefer let's move out of structure to go into Config > Content authoring (admin/config/content) as other Layout Builder related modules put their config entries into.
    2 if agreed, I make the route change, cleanup the MR
    3 I let you convert the empty controller into a settings form (or I can convert it into an empty settings form and give you the hand) because I am not sure what and how you want to save into config.

    What do you think about that?

  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    Ahh - I like admin config! Thank you for pointing out the user entity; that's a great example.

    Your idea makes the settings form approach make more sense. I was actually already working on that conversion and removing the duplicate menu item from the yml under admin/content. How about I push my initial changes in a few and you can take look at what you think?

  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    Nice!

    Yes push.

    I will not have time to work on that until this weekend, so you have the time :)

  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    Excellent! Just pushed an update to your MR that moves the field UI below admin/config, the section library view is now only a task below admin/content by default, and I replaced the controller with a settings form (with and update hook, install settings file, and schema)

    The label settings haven't been incorporated but I can work on that next.

  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    Thanks!

    I will try to try-out that this weekend.

  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    Thank you! I'm excited about this approach.

  • πŸ‡ΊπŸ‡ΈUnited States jastraat
  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    The MR now includes a settings form with the ability to customize the labels of the two types of templates. That form is the new parent for the field UI tabs. Also attaching a patch based on the MR.

  • πŸ‡ΊπŸ‡ΈUnited States jastraat


  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    Thanks for the work.

    Testing and reviewing.

  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    When I tried to reinstall section_library, I got the following error:

    Configuration objects (views.view.section_library) provided by section_library already exist in active configuration  
    

    The view had not been deleted when uninstalling the module.

  • Pipeline finished with Canceled
    3 months ago
    Total: 126s
    #424537
  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    Good for me.

    If you want to review and test with my changes.

  • Pipeline finished with Success
    3 months ago
    Total: 144s
    #424539
  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    I tweaked a few things:

    • Tweaked the config_translation.yml to match the documentation. Thank you for adding this! I tested the newest MR with the core config translation module and it worked great. The only potential issue I see is that the add links are still mostly untranslated. Only the labels are being translated.
    • I removed a few more instances where I had put a 2nd parameter into config get.

    I'm not sure that I can be the reviewer here since a lot of the code was mine. We may need to get a 3rd party...?

  • πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

    Thanks :)

    Hum, I think you can ask Rajab for a quick review. :)

  • πŸ‡ΊπŸ‡ΈUnited States jastraat
  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    I've pinged him in section_library Slack -

  • πŸ‡ΊπŸ‡ΈUnited States jastraat
  • πŸ‡ΊπŸ‡ΈUnited States tlilleberg

    All testing steps pass for me. Everything looks good:

    Confirm that section library tab appears below admin/content again

    Confirm that new setting form appears below admin/config/content along with the field UI tabs

    Visit a layout tab and confirm that the UI is unchanged from what it was with the links, buttons, and selects for adding and importing section templates

    Back on the new config form, customize the section and template labels.
    Confirm that the UI on the layout tab uses the customized labels.

  • πŸ‡ΊπŸ‡ΈUnited States tlilleberg
  • πŸ‡ΊπŸ‡ΈUnited States tlilleberg
  • Pipeline finished with Skipped
    3 months ago
    #426873
  • πŸ‡ΊπŸ‡ΈUnited States jastraat
  • πŸ‡ΊπŸ‡ΈUnited States jastraat

    Updating this to the relevant major version.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024