- Issue created by @Grimreaper
- π«π·France Grimreaper France π«π·
Or "field UI" tabs need to be moved in Admin > Structure, not the place in Admin > Content.
- Merge request !41Issue #3505832: Restore the tab to section library collection and move field UI to admin/config β (Merged) created by Grimreaper
- π«π·France Grimreaper France π«π·
I made a very straight forward POC to open discussion.
- πΊπΈUnited States jastraat
I agree that the field UI makes more sense under Admin Structure. What are you proposing as the parent for those tabs? Are you adding a new route?
I also love that folks are actually trying this out! - π«π·France Grimreaper France π«π·
With screenshots, maybe easier to visualize :)
- π«π·France Grimreaper France π«π·
I am not in favor of splitting "section" and "template" into 2 bundles, the current structure is OK.
One of the content entity type from core that has no bundle is user. And it's equivalent of index is "admin/config/people/accounts" which is a global user account related settings form. So way more similar like the settings form you propose.
As mentioned in the MR comments, I had to have a route to attach the Field UI routes on. And currently, no better stuff than an empty controller. Maybe with an explanatory text.
So:
1 if you prefer let's move out of structure to go into Config > Content authoring (admin/config/content) as other Layout Builder related modules put their config entries into.
2 if agreed, I make the route change, cleanup the MR
3 I let you convert the empty controller into a settings form (or I can convert it into an empty settings form and give you the hand) because I am not sure what and how you want to save into config.What do you think about that?
- πΊπΈUnited States jastraat
Ahh - I like admin config! Thank you for pointing out the user entity; that's a great example.
Your idea makes the settings form approach make more sense. I was actually already working on that conversion and removing the duplicate menu item from the yml under admin/content. How about I push my initial changes in a few and you can take look at what you think?
- π«π·France Grimreaper France π«π·
Nice!
Yes push.
I will not have time to work on that until this weekend, so you have the time :)
- πΊπΈUnited States jastraat
Excellent! Just pushed an update to your MR that moves the field UI below admin/config, the section library view is now only a task below admin/content by default, and I replaced the controller with a settings form (with and update hook, install settings file, and schema)
The label settings haven't been incorporated but I can work on that next.
- π«π·France Grimreaper France π«π·
Thanks!
I will try to try-out that this weekend.
- πΊπΈUnited States jastraat
Thank you! I'm excited about this approach.
- πΊπΈUnited States jastraat
The MR now includes a settings form with the ability to customize the labels of the two types of templates. That form is the new parent for the field UI tabs. Also attaching a patch based on the MR.
- π«π·France Grimreaper France π«π·
Thanks for the work.
Testing and reviewing.
- π«π·France Grimreaper France π«π·
When I tried to reinstall section_library, I got the following error:
Configuration objects (views.view.section_library) provided by section_library already exist in active configuration
The view had not been deleted when uninstalling the module.
- π«π·France Grimreaper France π«π·
Good for me.
If you want to review and test with my changes.
- πΊπΈUnited States jastraat
I tweaked a few things:
- Tweaked the config_translation.yml to match the documentation. Thank you for adding this! I tested the newest MR with the core config translation module and it worked great. The only potential issue I see is that the add links are still mostly untranslated. Only the labels are being translated.
- I removed a few more instances where I had put a 2nd parameter into config get.
I'm not sure that I can be the reviewer here since a lot of the code was mine. We may need to get a 3rd party...?
- π«π·France Grimreaper France π«π·
Thanks :)
Hum, I think you can ask Rajab for a quick review. :)
- πΊπΈUnited States jastraat
I've pinged him in section_library Slack -
- πΊπΈUnited States tlilleberg
All testing steps pass for me. Everything looks good:
Confirm that section library tab appears below admin/content again
Confirm that new setting form appears below admin/config/content along with the field UI tabs
Visit a layout tab and confirm that the UI is unchanged from what it was with the links, buttons, and selects for adding and importing section templates
Back on the new config form, customize the section and template labels.
Confirm that the UI on the layout tab uses the customized labels.
-
jastraat β
committed a7a88d2a on 1.2.x authored by
grimreaper β
Issue #3505832 by jastraat, grimreaper: Restore the tab to section...
-
jastraat β
committed a7a88d2a on 1.2.x authored by
grimreaper β
-
jastraat β
committed a7a88d2a on 2.0.x authored by
grimreaper β
Issue #3505832 by jastraat, grimreaper: Restore the tab to section...
-
jastraat β
committed a7a88d2a on 2.0.x authored by
grimreaper β
- πΊπΈUnited States jastraat
Updating this to the relevant major version.
Automatically closed - issue fixed for 2 weeks with no activity.