Contrib.social

[Feature Request] - If no image alt is present look for description instead

Open on Drupal.org →
Created on 10 February 2025, about 2 months ago

Problem/Motivation

On a lot of our projects we have a media entity called SVG where a user can upload a file and use it as though it is an image wherever they use media. The file field does not come with alt text so we repurpose the description on the file field instead. In the images column of the xml sitemap the images all display their alt text as the link text but for SVG files which have been used in media fields it displays the filename instead.

Steps to reproduce

Create two media types - one for images and one for files called SVG. Upload one of each and attach to a page via a media field on some content. Add this content to the sitemap and go to /sitemap.xml. The image will display with the alt text as the link text but the SVG will display the filename instead.

Proposed resolution

In /src/Plugin/simple_sitemap/UrlGenerator/EntityUrlGeneratorBase.php instead of setting the alt like this:
'alt' => $item->alt do this instead: 'alt' => $item->alt ?? $item->description

This means no change to existing functionality but does allow a fallback to using the file's description field if it has content.

Remaining tasks

Once PR created please test and feedback to me.

User interface changes

SVG files will now display description text if available before falling back to filename as it currently behaves.

API changes

None.

Data model changes

None.

✨ Feature request
Status

Active

Version

4.2

Component

Code

Created by

🇬🇧United Kingdom darren.fisher

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024