Run GitLabCI pipelines

I have created MR3 and the pipeline runs.

When this is merged we can work on the failing jobs, but first we need to get the composer job to run sucessfully.

The composer job shows this conflict.

Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - Root composer.json requires drupal/core-recommended 11.1.1 -> satisfiable by drupal/core-recommended[11.1.1].
    - Root composer.json requires roave/security-advisories dev-master -> satisfiable by roave/security-advisories[dev-master].
    - drupal/core-recommended 11.1.1 requires twig/twig ~v3.16.0 -> satisfiable by twig/twig[v3.16.0].
    - roave/security-advisories dev-master conflicts with twig/twig v3.16.0.

But I now see from the project page that 3.0.0-beta2 does not claim to be compatible with Drupal 11, so that probably explains it. I'm not familiar with Faker, but I came here due to my work on both Devel Generate and Gitlab Templates, and was thinking I could help here.

I can easily modify the gitlab template so that it runs the code quality tests at Drupal core 10, not 11, if that is the plan for the 3.x branch. I see you also have 🌱 [META] Plan for Faker 4.0.0 Active so maybe your plan is to have that branch compatible with D11.

I'm happy to help here, and will wait for your guidance on what the plans are for core compatibility with 3.x

Hi @jonathan1055,

I think we can still support D11 in either 3.0.x or 3.1.x depending on the changes. 4.x is mainly to decouple more from Devel Generate via a submodule or similar as per #3186907: Abstract from devel_generate → .

Happy to give you co-maintainership too if you're interested? Thanks!

Happy to give you co-maintainership too if you're interested?

Thank you for the offer. But I will just help out here, for now, as I know nothing about the module yet.

... we can still support D11 in either 3.0.x or 3.1.x depending on the changes.

OK, that's good. We can work on that. I see that it is only the .info.yml file that sets core_version_requirement: ^9.3 || ^10. There is no

  "require": {
    "drupal/core": "^9.3 || ^10",

in composer.json. I'm not sure, but is it good practice to have the core version specified in both places?

in composer.json. I'm not sure, but is it good practice to have the core version specified in both places?

I believe the .info.yml file should suffice for the constraints yes.

FYI, for it to be D11 compatible, we will run in additional Interface compatibility issues as seen in 🐛 Unable to access the Devel Generate Content and Generate User Settings forms after enabling Faker module Active , depending on the version of Devel Generate.

Hmm I can't seem to disable the current composer job. (Trying to have it run on D10 only for now)

Looking at the build https://git.drupalcode.org/project/faker/-/pipelines/420180 now, I think I understand what you were referring to with #6 now. As it shouldn't be able to install with composer when not compatible w/ D11, yet it was able to.

I can't seem to disable the current composer job

This is because the linting and code-quality jobs all "need" the current composer job. But that is working fine, now that you have made a few changes to composer.json

If the project had phpunit tests then the core version requirements in .info.yml would be more important, and would stop the tests running at D11. But I think this is fine as-is. I also agree with you that the core version is not needed in composer.json, and infact I read some documentation saying that it is best not to have it duplicated, unless you really need it for external reasons.

So I think MR3 is ready for review and then merging, then we can work on fixing the other jobs in follow-up issues. It will be good to get the initial .gitlab-ci.yml committed.

Merged now, thanks for the help!

Automatically closed - issue fixed for 2 weeks with no activity.