- Issue created by @roderik
- π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
Uploading patch for 8.x-1.x to this issue too, for 'fixed' reference for our build system. It can apply to 3.x too, the code is the same, it's just 18 lines higher up in the .module file.
I admit to only live-testing the 8.x-1.x version on our system, but I don't really see how there would be a difference between the two versions in this respect.
Pipeline for 3.x MR is green, so I assume pipeline for 8.x-1.x MR is not failing harder than usual.
- First commit to issue fork.
- πΊπΈUnited States pfrilling Minster, OH
I think that approach makes sense. I added functional testing to confirm the forms are loading correctly, which uncovered a caching issue.
Marking this RTBC for now.
-
pfrilling β
committed dd6e5d2a on 3.x authored by
roderik β
Issue #3504763 by roderik, pfrilling: Fatal error when building user...
-
pfrilling β
committed dd6e5d2a on 3.x authored by
roderik β
- πΊπΈUnited States pfrilling Minster, OH
Needs to be ported to the 1.x branch yet.
- π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
That's MR!139.
(I'm going out on a limb that you're not needing to add tests there.)
- πΊπΈUnited States pfrilling Minster, OH
This has been merged to the 1.x branch now. I'm okay with the tests failing there for now. It's the same code in the 3.x branch, which is confirmed with test.
- π³π±Netherlands roderik Amsterdam,NL / Budapest,HU
@pfrilling sorry, I should have added the change in caching the form, to MR!139.
If you merge + push to 8.x-1.x without this change, I guess that's fine and we can wait until upgrading to the 3.x branch, until we see this fixed in practice.
(This change is not closely related to the reported issue, but it's valid, I can confirm that I've seen the caching issue.)
-
pfrilling β
committed 2618dcaa on 8.x-1.x authored by
roderik β
Issue #3504763 by roderik, pfrilling: Fatal error when building user...
-
pfrilling β
committed 2618dcaa on 8.x-1.x authored by
roderik β
- πΊπΈUnited States pfrilling Minster, OH
Thanks for the cherry pick and the reminder to actually commit the changes. Note to self, the merge train option doesn't work if the pipeline is failing :facepalm: Now, this is officially fixed.
- π¨π¦Canada joseph.olstad
Alpha6 β causes an issue in keycloak reported by two others
I'm not sure which change in alpha6 is causing this.
Automatically closed - issue fixed for 2 weeks with no activity.