Contrib.social

Libraries needed only inside the preview iframe are loaded for the entire UI

Open on Drupal.org →
Created on 5 February 2025, about 1 month ago

Overview

A new concept, transforms, has been recently introduced for Redux-integrated field widgets in 📌 Move clientside assumptions about prop form data shape into a series of prop specific transforms Active . Transforms can be defined in libraries (with their names prefixed with xb.transform). As such, the implementation in \Drupal\experience_builder\Controller\ExperienceBuilderController was updated to attach these libraries. The change mistakenly merged the list of libraries needed for the XB app with the libraries needed to render the preview, where the active theme's libraries — in addition to system/base — are loaded in the iframe.

Here are the most visible symptoms using Olivero as the active theme:

Proposed resolution

Separate the libraries needed only for the preview, and make this more apparent in the code by adjusting variable names and adding comments.

🐛 Bug report
Status

Needs work

Version

0.0

Component

Page builder

Created by

🇳🇱Netherlands balintbrews Amsterdam, NL

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024