- Issue created by @larowlan
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This will result in a critical update to
docs/redux-integrated-field-widgets.md
that π Experiments in rendering Twig as React Active introduced, and I expect this to make that table more complete and more green/yellow, less red! π₯³ - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
AFAICT this is also a pre-requisite to be able to fix #3500385?
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This already looks fantastic! It looks like this will go a long way in making our Redux-integrated field widgets scale to the entire ecosystem, and will allow us to remove a lot of hardcoded shenanigans π
Detailed feedback on the MR, including suggestions for the questions you left in there.
P.S.: I think this means we'll be able to remove the hacky addition to
\Drupal\experience_builder\PropExpressions\StructuredData\Evaluator::evaluate()
that π Implement saving block settings forms Active added for the client-side datetime manipulation stuff? π€π - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
FYI: the remaining e2e test failure in
publish-button.cy.js
is one we've seen before β e.g. https://git.drupalcode.org/project/experience_builder/-/jobs/4200048 for the Jan 31 test run of HEAD at the time: https://git.drupalcode.org/project/experience_builder/-/commit/2756b20d9... - π¬π§United Kingdom longwave UK
Yup that test failure is logged at π publish-button.cy.js test is flaky Active
- π¬π§United Kingdom longwave UK
MR looks good to me, I guess we will find out when contrib/etc starts implementing more of these transformers.
-
wim leers β
committed 3b4df65a on 0.x
Issue #3499554 by wim leers, larowlan, longwave: Move client-side...
-
wim leers β
committed 3b4df65a on 0.x
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Usually, I'd like the main code owner for , @bnjmnm, to review this.
But:
- @larowlan did the critical front-end pieces of this MR, and he's a fellow code owner of that area
- zero UI tests were changed, which shows this is a pure refactor
- it clearly moves the needle forward, by introducing a needed abstraction that we can continue to refine in the future β it moves logic that was hardcoded in
ui/src/components/form/formUtil.ts
toui/src/utils/transforms.ts
@larowlan already updated docs. He also added unit tests.
So: being bold, to gain some much-needed progress on the ~5 month old meta π Some components cannot be used in XB because UI prevents SDC props being named `name` Active that is still open, of which this resolves one piece π
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Next up:
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
It looks like this also solved π Discover cases where is no 1:1 map between field, prop and widget values Active ?
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I realized while working on subsequent issues that this issue's MR did update
docs/redux-integrated-field-widgets.md
by adding a new section, but it didn't update the "spectrum" section yet that aims to provide an overview of what's done, what remains etc.So, created https://git.drupalcode.org/project/experience_builder/-/merge_requests/617 to update it, and make it less bleak π
-
wim leers β
committed 6f8166de on 0.x
Issue #3499554 by wim leers, larowlan, longwave: [docs] Move client-side...
-
wim leers β
committed 6f8166de on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.