- Issue created by @mstrelan
- πΊπΈUnited States pfrilling Minster, OH
The code looks fine to me. I left a comment on the MR about handling the exception. What do you think?
- π¦πΊAustralia mstrelan
That's a tricky one to answer. The only place this module is calling createUser is in
OpenIDConnect::completeAuthorization
, and that already has checks to see if the user already exists. In that case it would be fine for the exception to bubble up. The doc block for\Drupal\externalauth\ExternalAuthInterface::register
doesn't mention that it throws that exception either, so in theory any concrete class implementing that interface doesn't need to throw that exception either. So I think bubbling up would be fine. - πΊπΈUnited States pfrilling Minster, OH
Thanks for the validation @mstrelan. I think this all looks good.
-
pfrilling β
committed 6a6f708a on 3.x authored by
mstrelan β
Issue #3504426 by mstrelan, pfrilling: OpenIDConnect::createUser return...
-
pfrilling β
committed 6a6f708a on 3.x authored by
mstrelan β