- Issue created by @yobottehg
- π¨πSwitzerland yobottehg Basel
yobottehg β changed the visibility of the branch 3504243-n-gram-and-edgen-gram to hidden.
- Merge request !79[#3504243] Work around limitation on opensearch max_ngram_diff settings β (Merged) created by yobottehg
- π¨πSwitzerland yobottehg Basel
this is ony a demonstration.
The phpstan fails come out of deprecations of opensearch 2.4.0
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Is this something you can change directly on opensearch? We don't try and provide all the possible settings via the module. There would just be too many.
- π¨πSwitzerland yobottehg Basel
Yes sure it is possible.
However previously it was possible to use this module with zero config opensearch containers like on lando / ddev / platform.sh.
Now this this not work anymore if an ngram or edge ngram field is used as the min / max config set on the analyser is not enough anymore.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
New commits go into 3.x
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
@yobottehg I've rebased this on 3.x.
Can you explain why you chose a value of 20 rather than any other arbitrary number? Also, should this be configurable?
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Made it configurable and added an update hook. @yobottehg it would be great if you could test this out manually.
- π¨πSwitzerland yobottehg Basel
Can you explain why you chose a value of 20 rather than any other arbitrary number? Also, should this be configurable?
I chose 20 because of the setting of min_gram: 1 and max_gram: 20 on the analyser.
Made it configurable and added an update hook. @yobottehg it would be great if you could test this out manually.
Tested it locally. After setting the number to atleast 19, updating an index with edge-n_gram fields worked again.
-
kim.pepper β
committed b6666774 on 3.x authored by
yobottehg β
Issue #3504243 by kim.pepper, yobottehg: N-gram and edge_N-gram...
-
kim.pepper β
committed b6666774 on 3.x authored by
yobottehg β
-
kim.pepper β
committed e298e102 on 2.x authored by
yobottehg β
Issue #3504243 by kim.pepper, yobottehg: N-gram and edge_N-gram...
-
kim.pepper β
committed e298e102 on 2.x authored by
yobottehg β
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Committed to 2x. and 3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.