- Issue created by @SirClickALot
- First commit to issue fork.
- Merge request !23Issue #3503939 by mably: Allow for customisation of the pop-up dialog → (Merged) created by mably
- First commit to issue fork.
- 🇫🇷France mably
@sirclickalot could you give a try to this issue's MR?
Here is the new jQuery dialog settings:
- 🇬🇧United Kingdom SirClickALot Somerset
Should apply the associate patch (23.patch) to my current
^4.2@alpha
version? - 🇫🇷France mably
@sirclickalot I've finally added two news settings to the jQuery UI dialog configuration:
I hope you'll like it 😉
- 🇬🇧United Kingdom SirClickALot Somerset
Hi @mably → ,
When I apply the patch from the MR in #9, I see the follow pre-flight...
I then get a series of 'complaints' along these lines...
A few clicks later down the line and my IDE says that "...patch applied but with errors..." or something like that.
The upshot of all this is that some of the functionality is certainly there but I don't think everything is working. For example, I am able to configure a desired setting and this does seem to persist after saving the configuration...
However, when I try it out in the front end, while it is undoubtedly different to before, the dialog appears to be adopting a default height which is much too high for the enclosed content and a width set at 500px (I get from the Inspector)...
I'm not sure my visual evidence here is particularly useful given that the patch didn't apply cleanly at all but I hope it helps in some way.
- 🇮🇳India vinayakmk47
Hi @sirclickalot check the changes i made and review please let me know if there are any changes required.
- 🇬🇧United Kingdom SirClickALot Somerset
Hi @vinayakmk47,
I'm afraid I don't understand what you mean here by "...check the changes I made..."
What exactly do you want me to check?
- 🇫🇷France mably
@sirclickalot 500px are the new default width and height for the dialog. It can be changed.
- 🇫🇷France mably
@sirclickalot it has been merged in dev branch 4.2.x, should be easier to deploy.