Change the pipline service from with-chrome to with-selenium-chrome

@rkoller Can you look at line 89 of https://git.drupalcode.org/project/drupal/-/merge_requests/11003/diffs

I mean it looks like you might need to edit line 89 of the gitlab.yml. Not sure you edited the right line?

isn't line 89 defining the with-selenium-chrome test? but what the problem was was that test-only changes used with-chrome instead. and this MR changes using with-selenium-chrome for the test-only tests instead of with-chrome.

Ok, I see.

If I understand correctly, with-chrome means to use the service (Docker container) $_CONFIG_DOCKERHUB_ROOT/chromedriver:production, and with-selenium-chrome: means to use the service selenium/standalone-chrome:127.0. (Presumably the version will be updated as needed.)

After the change in MR 11021, the only tests in pipeline.yml using with-chrome will be 🖱️️️ PHPUnit Functional Javascript (non W3C legacy) and 🚲 Performance tests.

I notice there is also a 🩹 Test-only changes job defined in pipeline-test-only.yml. That job already has the service selenium/standalone-chrome:latest.

I am not at all sure how all this fits together, but

1. The change in MR 11021 (switching to selenium-standalone-chrome looks like it will make the two jobs more consistent.
2. I am surprised that there are two jobs with so much in common and yet not identical.

I am also not sure why we have two "test only" jobs defined in separate pipelines but that's out of scope here.

Eventually the "non W3C" with-chrome will go away and we will only use the Selenium drivers, so this is a good step towards that.

Opened 📌 Reconcile test-only jobs Active to look at the two test-only jobs.

Committed/pushed to 11.x, thanks!

catch → closed merge request !11021

Automatically closed - issue fixed for 2 weeks with no activity.