- Issue created by @fjgarlin
- πͺπΈSpain fjgarlin
This will show up a generic short message to the front-end while still logging the full message via the logger service.
Ready for review. - πΊπΈUnited States phenaproxima Massachusetts
I think this is a great idea.
I would maybe rephrase the error, though. How about something like:
An error occurred while fetching data from drupal.org. See the error log β for details, or report the issue β . While this error persists, you can browse the project catalog on drupal.org β .
- πͺπΈSpain fjgarlin
Suggestion from #7 about the text applied, except that I didn't offer a link in the words "error log" and that the link to report an issue is against the "drupalorg" project. We can triage the issue from there and move back to PB queue if needed (also, PB might be merged into core at some point so the link would need to change).
- πΊπΈUnited States tim.plunkett Philadelphia
fjgarlin β credited tim.plunkett β .
- πΊπΈUnited States phenaproxima Massachusetts
One further suggestion but otherwise I'm fine with your changes.
- πΊπΈUnited States phenaproxima Massachusetts
Not sure how to manually test this, but I think that this is a much better user experience which doesn't compromise debuggability, since it logs the original error.
- πͺπΈSpain fjgarlin
Easy to test manually via Drupalpod. See the change that I cleaned up in this commit: https://git.drupalcode.org/project/project_browser/-/merge_requests/685/...
If you add that bit, you can see the error message. Just don't commit it (like I did π).
- First commit to issue fork.
-
chrisfromredfin β
committed c9585fa8 on 2.0.x authored by
fjgarlin β
Issue #3502465 by fjgarlin, phenaproxima, tim.plunkett: Reduce the...
-
chrisfromredfin β
committed c9585fa8 on 2.0.x authored by
fjgarlin β
- πΊπΈUnited States chrisfromredfin Portland, Maine
Clean up error messages, always a better UX.
- πͺπΈSpain fjgarlin
Some language nitpicks https://git.drupalcode.org/project/project_browser/-/merge_requests/687/...
-
chrisfromredfin β
committed 3caebcc4 on 2.0.x authored by
fjgarlin β
Issue #3502465 by fjgarlin, chrisfromredfin, phenaproxima, tim.plunkett...
-
chrisfromredfin β
committed 3caebcc4 on 2.0.x authored by
fjgarlin β
Automatically closed - issue fixed for 2 weeks with no activity.