Created on 27 January 2025, 2 months ago

Problem/Motivation

tests need fixed.

Proposed resolution

Fix the tests.

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tonytheferg
  • phpstan

      Line   src/Form/VadoManagementForm.php                                       
     ------ ---------------------------------------------------------------------- 
      59     Method Drupal\Core\Form\ConfigFormBase::__construct() invoked with 1  
             parameter, 2 required.                                                
     ------ ---------------------------------------------------------------------- 
     ------ ----------------------------------------------------------------------- 
      Line   src/Plugin/Commerce/VadoGroupWidget/VadoGroupWidgetBase.php            
     ------ ----------------------------------------------------------------------- 
      465    Call to deprecated method renderPlain() of interface                   
             Drupal\Core\Render\RendererInterface:                                  
             in drupal:10.3.0 and is removed from drupal:12.0.0. Use                
               \Drupal\Core\Render\RendererInterface::renderInIsolation() instead.  
  • Merge request !23Resolve #3502433 "Fix tests" → (Closed) created by tonytheferg
  • Merge request !24Resolve #3502433 "Fix tests" → (Merged) created by tonytheferg
  • That took care of phpstan and test failures, just have this left:

    3 tests triggered 2 PHP warnings:
    1) /builds/project/commerce_vado/web/core/modules/user/tests/src/Traits/UserCreationTrait.php:172
    Array to string conversion
    Triggered by:
    * Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroup
      /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:180
    * Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupDuplicate
      /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:236
    * Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupItemGroup
      /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:206
    2) /builds/project/commerce_vado/web/core/modules/user/tests/src/Traits/UserCreationTrait.php:188
    Array to string conversion
    Triggered by:
    * Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroup
      /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:180
    * Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupDuplicate
      /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:236
    * Drupal\Tests\commerce_vado\Kernel\Entity\VadoGroupTest::testVadoGroupItemGroup
      /builds/project/commerce_vado/tests/src/Kernel/Entity/VadoGroupTest.php:206
    OK, but there were issues!
    Tests: 14, Assertions: 611, Warnings: 2.
  • Pipeline finished with Skipped
    2 months ago
    #407290
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024